Feature/account fiscal position rule purchase migration 8.0 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatonlima
force-pushed
the
feature/account_fiscal_position_rule_purchase_migration_8.0
branch
from
858289c
to
e8ac579
Compare
rvalyi
force-pushed
the
feature/account_fiscal_position_rule_purchase_migration_8.0
branch
from
ff2b2ac
to
6ea90bf
Compare
|
just rebased on 8.0 so tests are passing again. Need review now. |
|
👍 |
rvalyi
force-pushed
the
feature/account_fiscal_position_rule_purchase_migration_8.0
branch
from
6ea90bf
to
329f931
Compare
|
ping @mileo @danimaribeiro time for a review? |
|
LGTM 👍 |
| <field name="arch" type="xml"> | ||
| <field name="partner_id" position="attributes" > | ||
| <attribute name="context_fiscalrules">{'company_id': company_id}</attribute> | ||
| </field> |
There was a problem hiding this comment.
web_context_tunnel is needed in the depends.
|
You could add view and model folders, and remove the file account_fiscal_position_rule_purchase_security.xml which is empty. The rules are working as expected after adding web_context_tunnel as dependency. |
rvalyi
force-pushed
the
feature/account_fiscal_position_rule_purchase_migration_8.0
branch
from
329f931
to
4de9032
Compare
rvalyi
force-pushed
the
feature/account_fiscal_position_rule_purchase_migration_8.0
branch
from
5b14e24
to
fc9b5f8
Compare
|
@danimaribeiro took your considerations into account. Good catch about the missing web_context_tunnel dependency. So merging now as the module was approved otherwise. |
rvalyi
added a commit
that referenced
this pull request
Oct 1, 2015
…rule_purchase_migration_8.0 Feature/account fiscal position rule purchase migration 8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.