Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0][IMP] account_fiscal_position_rule: Refactoring #73

Merged

Conversation

renatonlima
Copy link
Member

No description provided.

@pedrobaeza
Copy link
Member

Isn't this already migrated in #61?

@renatonlima renatonlima force-pushed the 10.0-migration/account_fiscal_position_rule branch from b8228b7 to 6644952 Compare December 14, 2017 11:03
@renatonlima renatonlima changed the title 10.0 migration/account fiscal position rule Refactoring account fiscal position rule Dec 14, 2017
@renatonlima
Copy link
Member Author

Hello @pedrobaeza,

In fact, the module is already migrated, I just did a refactoring, I changed commits message and PR title.

@pedrobaeza pedrobaeza changed the title Refactoring account fiscal position rule [10.0] account_fiscal_position_rule: Refactoring Dec 14, 2017
@pedrobaeza pedrobaeza changed the title [10.0] account_fiscal_position_rule: Refactoring [10.0][IMP] account_fiscal_position_rule: Refactoring Dec 14, 2017
@pedrobaeza
Copy link
Member

I have changed the title to adjust to conventions 😉

@pedrobaeza pedrobaeza added this to the 10.0 milestone Dec 14, 2017
Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrobaeza pedrobaeza merged commit 0b8b511 into OCA:10.0 Sep 13, 2018
renatonlima added a commit to akretion/account-fiscal-rule that referenced this pull request Dec 28, 2018
* [REF] account_fiscal_position_rule_template
* [REF] account_fiscal_position_rule
* [REF] wizard.account.fiscal.position.rule
* [REF] xml files
ThomasBinsfeld pushed a commit to acsone/account-fiscal-rule that referenced this pull request Jan 17, 2020
* [REF] account_fiscal_position_rule_template
* [REF] account_fiscal_position_rule
* [REF] wizard.account.fiscal.position.rule
* [REF] xml files
ThomasBinsfeld pushed a commit to acsone/account-fiscal-rule that referenced this pull request Mar 5, 2020
* [REF] account_fiscal_position_rule_template
* [REF] account_fiscal_position_rule
* [REF] wizard.account.fiscal.position.rule
* [REF] xml files
ThomasBinsfeld pushed a commit to acsone/account-fiscal-rule that referenced this pull request Mar 19, 2020
* [REF] account_fiscal_position_rule_template
* [REF] account_fiscal_position_rule
* [REF] wizard.account.fiscal.position.rule
* [REF] xml files
ThomasBinsfeld pushed a commit to acsone/account-fiscal-rule that referenced this pull request Mar 19, 2020
* [REF] account_fiscal_position_rule_template
* [REF] account_fiscal_position_rule
* [REF] wizard.account.fiscal.position.rule
* [REF] xml files
dnplkndll pushed a commit to Kencove/account-fiscal-rule that referenced this pull request Dec 3, 2020
* [REF] account_fiscal_position_rule_template
* [REF] account_fiscal_position_rule
* [REF] wizard.account.fiscal.position.rule
* [REF] xml files
MiquelRForgeFlow pushed a commit to ForgeFlow/account-fiscal-rule that referenced this pull request Mar 28, 2023
* [REF] account_fiscal_position_rule_template
* [REF] account_fiscal_position_rule
* [REF] wizard.account.fiscal.position.rule
* [REF] xml files
MiquelRForgeFlow pushed a commit to ForgeFlow/account-fiscal-rule that referenced this pull request Mar 28, 2023
* [REF] account_fiscal_position_rule_template
* [REF] account_fiscal_position_rule
* [REF] wizard.account.fiscal.position.rule
* [REF] xml files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants