Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG][12.0] account_fiscal_position_type (from 8.0) #94

Merged
merged 4 commits into from
May 4, 2020
Merged

[MIG][12.0] account_fiscal_position_type (from 8.0) #94

merged 4 commits into from
May 4, 2020

Conversation

legalsylvain
Copy link
Contributor

@legalsylvain legalsylvain commented Jul 11, 2019 •
edited

Port account_fiscal_position_type from 8.0 to 12.0.

Module :
New module that adds type_position_use field on account.fiscal.position model. possible value ('sale' / 'purchase' / 'all' as for account.tax). If set, fiscal position will be available on out or in invoices, limiting incorrect values.

See : #93

CC : @pedrobaeza, @renatonlima, @rvalyi, @PierrickBrun, @quentinDupont

#GRAPOCA

@legalsylvain legalsylvain added this to the 12.0 milestone Jul 11, 2019
@legalsylvain legalsylvain force-pushed the 12.0-mig-account_fiscal_position_type branch from d9df204 to b657375 Compare August 20, 2019 17:02
@legalsylvain legalsylvain mentioned this pull request Jan 8, 2020
Merged
@legalsylvain
Copy link
Contributor Author

/ocabot merge

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-94-by-legalsylvain-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 18, 2020
@OCA-git-bot
Merge PR #94 into 12.0
58c31f9 
Signed-off-by legalsylvain
@OCA-git-bot
Copy link
Contributor

@legalsylvain your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-94-by-legalsylvain-bump-no.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@legalsylvain legalsylvain force-pushed the 12.0-mig-account_fiscal_position_type branch from b657375 to 0e88e68 Compare March 19, 2020 08:23
@legalsylvain legalsylvain force-pushed the 12.0-mig-account_fiscal_position_type branch from 0e88e68 to 236571a Compare March 19, 2020 08:25
@legalsylvain legalsylvain changed the title 12.0 mig account fiscal position type [MIG][12.0] account_fiscal_position_type (from 8.0) Mar 19, 2020
@quentinDupont quentinDupont mentioned this pull request Apr 20, 2020
Merged
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@legalsylvain
Copy link
Contributor Author

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-94-by-legalsylvain-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit edf6aca into OCA:12.0 May 4, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8ec4220. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quentinDupont quentinDupont quentinDupont approved these changes

@ThomasBinsfeld ThomasBinsfeld ThomasBinsfeld approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs fixing ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@legalsylvain @OCA-git-bot @quentinDupont @ThomasBinsfeld