[14.0][MIG] Module stock_picking_invoicing #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Loading * Onchanges Etc
* Good Price with pricelist * Good Taxes * group works * Everything is filtered with company
* Get the correct taxes and account regarding Fiscal Position
[IMP]Add the availability to choose the company that will invoice
Signed-off-by: Luis Felipe Mileo <mileo@kmee.com.br>
hparfr
reviewed
Nov 5, 2021
| @@ -498,15 +498,15 @@ def _update_picking_invoice_status(self, pickings): | |||
| return pickings._set_as_invoiced() | |||
|
|
|||
| def ungroup_moves(self, grouped_moves_list): | |||
| """ Ungrup your moves, split them again, grouping by | |||
| """Ungrup your moves, split them again, grouping by | |||
There was a problem hiding this comment.
Suggested change
| """Ungrup your moves, split them again, grouping by | |
| """Ungroup your moves, split them again, grouping by |
hparfr
reviewed
Nov 5, 2021
| fiscal position, max itens per invoice and etc | ||
| :param grouped_moves_list: | ||
| :return: list of grouped moves list | ||
| """ | ||
| return [grouped_moves_list] | ||
|
|
||
| def _create_invoice(self, invoice_values): | ||
| """ Overrite this metothod if you need to change any values of the | ||
| """Overrite this metothod if you need to change any values of the |
hildickethan-S73
approved these changes
Nov 12, 2021
rvalyi
requested changes
Nov 12, 2021
There was a problem hiding this comment.
Hello @mbcosta
- this commit seems an error: when removing such decorators, methods become @api.multi by default. Something there are not as they work on the RecordSet Model and not a recordset itself (look at other default_get declarations in other modules) f7662ba
- contributors are not expected to re-generate REAME files in specific commits such as 6773f41 as these are re-generated by the OCA bots anyway. So better if you remove that commit too.
- Once this commit is removed it's better if you squash 4fe918a onto the previous migration commit because such trivial code formating commits don't deserve dedicated commit (it pollutes the log).
Use rebase -i for this cleanup. The othercommits are OK.
mbcosta
force-pushed
the
14.0-mig-stock_picking_invoicing
branch
from
2d4d244
to
ed6eeba
Compare
rvalyi
approved these changes
Nov 12, 2021
|
This PR has the |
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at b782aa5. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration module stock_picking_invoicing to v14, the PR #1010 are missing the last commits made in v13:
cc @rvalyi @renatonlima @mileo @Zar21