8.0 add account_group_invoice_lines module #102
Conversation
… account move line
Update to OCA coding standards
|
Hey @alexis-via, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
|
|
||
| { | ||
| 'name': 'Account Group Invoice Lines', | ||
| 'version': '1.1', |
There was a problem hiding this comment.
Please update version according to https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#version-numbers
| _inherit = 'account.invoice' | ||
|
|
||
| def inv_line_characteristic_hashcode(self, invoice_line): | ||
| '''When grouping per account, we remove the product_id from |
There was a problem hiding this comment.
triple-""" is the norm I believe, and the first line should be a short description
|
|
||
| { | ||
| 'name': 'Account Group Invoice Lines', | ||
| 'version': '1.1.0', |
There was a problem hiding this comment.
Please also add at the beginning the Odoo version. Thanks.
There was a problem hiding this comment.
Odoo will automatically concatenate the version of Odoo (8.0) with the version of the module (1.1.0). So, with the current value for the version key, Odoo will display "8.0.1.1.0" as module version in the web user interface.
So do you really want me to put the version of Odoo at the beginning of the version number ?
There was a problem hiding this comment.
Please see this comment that explain the why: OCA/maintainer-tools#90 (comment)
|
@clonedagain @tafaRU |
|
and @alnslang told me he has signed OCA's CLA yesterday. |
|
Thanks, @alexis-via! Now LGTM 👍 |
|
👍 bien |
|
👍 |
1 similar comment
|
👍 |
8.0 add account_group_invoice_lines module
|
Hey @alexis-via,
Appreciation of efforts, |
Please refer to README for a full description of the module.
I think this module is really usefull and many accountants will like to be able to configure Odoo to have fewer account move lines in their sale and purchase journals !