[FIX] account_invoice_merge - record set used instead of list of ids in do_merge #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating to 8.0
…voice_merge_bugfixes [FIX] corrected part 'make link between original sale order'
account_invoice_merge/invoice.py
Outdated
| @@ -207,8 +206,9 @@ def make_key(br, fields): | |||
| [('product_id', '=', so_line.product_id.id), | |||
| ('invoice_id', '=', new_invoice_id)]) | |||
| if invoice_line_ids: | |||
| invoice_line_ids_list = [x.id for x in invoice_line_ids] | |||
There was a problem hiding this comment.
Would be better if you renamed that variable invoice_lines as search returns a record set. Thus you can do: invoice_lines.ids to get a list of ids.
yvaucher
changed the title
Conflicts: account_invoice_merge/models/account_invoice.py
Syncing from upstream OCA/account-invoicing (8.0)
Syncing from upstream OCA/account-invoicing (8.0)
Syncing from upstream OCA/account-invoicing (8.0)
Syncing from upstream OCA/account-invoicing (8.0)
Syncing from upstream OCA/account-invoicing (8.0)
Syncing from upstream OCA/account-invoicing (8.0)
Syncing from upstream OCA/account-invoicing (8.0)
Syncing from upstream OCA/account-invoicing (8.0)
Syncing from upstream OCA/account-invoicing (8.0)
Syncing from upstream OCA/account-invoicing (8.0)
Syncing from upstream OCA/account-invoicing (8.0)
[bt#871] Put new rounding line at the end of the invoice
|
Seems that was changed a lot from what I reviewed in 2015. The title of this PR is not reflecting the fix. I guess your change was dropped. You should also create a dedicated branch per PR to avoid changing state of a PR. Thus I will close the current PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
corrected part 'make link between original sale order'