12.0 account invoice negative total #1178
Conversation
victor-champonnois
force-pushed
the
12.0-account_invoice_negative_total
branch
from
6fc6047
to
d0e2a58
Compare
| @@ -0,0 +1,68 @@ | |||
| ======================== | |||
| Beescoop Account Module | |||
There was a problem hiding this comment.
The name of the module is not correct. :)
victor-champonnois
force-pushed
the
12.0-account_invoice_negative_total
branch
2 times, most recently
from
cc90f1f
to
dea7312
Compare
remytms
force-pushed
the
12.0-account_invoice_negative_total
branch
from
0ff6631
to
d8c9c72
Compare
remytms
force-pushed
the
12.0-account_invoice_negative_total
branch
from
d8c9c72
to
c36a94e
Compare
| if to_open_invoices.filtered(lambda inv: not inv.partner_id): | ||
| raise UserError( | ||
| _( | ||
| "The field Vendor is required, please complete it to " | ||
| "validate the Vendor Bill. " | ||
| ) | ||
| ) | ||
| if to_open_invoices.filtered(lambda inv: inv.state != "draft"): | ||
| raise UserError( | ||
| _("Invoice must be in draft state in order to validate it.") | ||
| ) | ||
| if to_open_invoices.filtered(lambda inv: not inv.account_id): | ||
| raise UserError( | ||
| _( | ||
| "No account was found to create the invoice, be sure you " | ||
| "have installed a chart of account. " | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Is this code copied from upstream Odoo? If yes, please add a comment saying as much. It will be pertinent during porting.
There was a problem hiding this comment.
It is already explained in the docstring of the method
| class TestInvoiceNegativeAmount(TransactionCase): | ||
| def setUp(self): |
There was a problem hiding this comment.
Let's use SavepointCase with setUpClass
There was a problem hiding this comment.
Why savepoint ?
There was a problem hiding this comment.
I tried using setupclass, it breaks the tests. I don't want to spend time fixing tests just to use setupclass.
account_invoice_negative_total/tests/test_account_invoice_open.py
Outdated
Show resolved
Hide resolved
victor-champonnois
force-pushed
the
12.0-account_invoice_negative_total
branch
from
bbc5f6f
to
76f12c2
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
New module allowing the validation an invoice with a negative total amount.