Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] account_invoice_change_currency #1261

Merged
merged 37 commits into from
May 26, 2023
Merged

[16.0][MIG] account_invoice_change_currency #1261

merged 37 commits into from
May 26, 2023

Conversation

ljsalvatierra-factorlibre
Copy link

@oca-clabot
Copy link

Hey @ljsalvatierra-factorlibre, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

AnizR
AnizR approved these changes Oct 11, 2022
View reviewed changes
Copy link

@AnizR AnizR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@ljsalvatierra-factorlibre ljsalvatierra-factorlibre mentioned this pull request Oct 13, 2022
Open
60 tasks
@ljsalvatierra-factorlibre ljsalvatierra-factorlibre changed the title [16.0][MIG] account invoice change currency [16.0][MIG] account_invoice_change_currency Oct 13, 2022
@ljsalvatierra-factorlibre ljsalvatierra-factorlibre force-pushed the 16.0-mig-account_invoice_change_currency branch 2 times, most recently from f3b013a to 59053e3 Compare December 22, 2022 09:01
@ljsalvatierra-factorlibre
Copy link
Author

Hi, is it ok to merge? Can anyone please take a look?

@RodrigoBM
Copy link

is it possible to merge this PR? @OCA/accounting-maintainers

@rafaelbn
Copy link
Member

/ocabot migration account_invoice_change_currency

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone May 25, 2023
@rafaelbn
Copy link
Member

Could you please show functionality in runboat in a 1 minute video?

Duc Dao and others added 17 commits May 26, 2023 07:36
@ljsalvatierra-factorlibre
[ADD] Add module account_invoice_change_currency
6081b4b 
[UPD] Update account_invoice_change_currency.pot
@ljsalvatierra-factorlibre
[MIG] account_invoice_change_currency: Migration to 11.0
dd2c5c0
@hugho-ad @ljsalvatierra-factorlibre
[12.0] account_invoice_change_currency migrate to v12.0
5b2e01f 
[REF] Update readme file

[UPD] README.rst

[UPD] Update account_invoice_change_currency.pot
@hugho-ad @ljsalvatierra-factorlibre
[REF] Move change currency button to a better place inside the invoic…
2e70b1b 
…e form

[UPD] README.rst
@hugho-ad @ljsalvatierra-factorlibre
[IMP] Avoid open extra_view
73bd4a9 
[IMP] Avoid store old currency in new field, instead of get it from tracking values from messages

[UPD] README.rst

[UPD] Update account_invoice_change_currency.pot
@hugho-ad @ljsalvatierra-factorlibre
[IMP]account_invoice_change_currency: Allow use a custom rate at conv…
2e73259 
…ertion

[IMP] account_invoice_change_currency: Allow set a a custom rate at currency conversion

[UPD] README.rst

[UPD] Update account_invoice_change_currency.pot
@hugho-ad @ljsalvatierra-factorlibre
[FIX] account_invoice_change_currency: the custom_rate field has a ba…
10cd3b3 
…d position in supplier invoices. (OCA#458)
@pedrobaeza @ljsalvatierra-factorlibre
Added translation using Weblate (Spanish)
ae4d350
@pedrobaeza @ljsalvatierra-factorlibre
Added translation using Weblate (Spanish (Mexico))
b785648
@hugho-ad @ljsalvatierra-factorlibre
[FIX] Fixed performance problem when search tracking values by subtype (
a290648 
OCA#470)

id, instead search them by messages ids then filter them
fix OCA#469

[REF] account_invoice_change_currency: Sql queries in order to improve performance

[FIX] account_invoice_change_currency: Fixed tests
@hugho-ad @ljsalvatierra-factorlibre
[FIX] account_invoice_change_currency: Failing when new invoice
7e88edc 
created, newid record not consider at onchange and get_last_currency
method

[UPD] Update account_invoice_change_currency.pot

Update translation files

Updated by Update PO files to match POT (msgmerge) hook in Weblate.
@mvrodriguez @ljsalvatierra-factorlibre
Translated using Weblate (Spanish)
64ea4d7 
Currently translated at 25.0% (2 of 8 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_change_currency
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_change_currency/es/
@OCA-git-bot @ljsalvatierra-factorlibre
[ADD] icon.png
d82a4f3
@BECJIE32 @ljsalvatierra-factorlibre
Translated using Weblate (Spanish)
3b1438d 
Currently translated at 87.5% (7 of 8 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_change_currency
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_change_currency/es/
@BECJIE32 @ljsalvatierra-factorlibre
Translated using Weblate (Spanish)
35d23b7 
Currently translated at 100.0% (8 of 8 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_change_currency
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_change_currency/es/
@marylla @ljsalvatierra-factorlibre
Added translation using Weblate (German)
47a476e
@marylla @ljsalvatierra-factorlibre
Translated using Weblate (German)
7927d1d 
Currently translated at 12.5% (1 of 8 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_change_currency
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_change_currency/de/
badbole and others added 16 commits May 26, 2023 07:36
@badbole @ljsalvatierra-factorlibre
Added translation using Weblate (Croatian)
b0aa202
@badbole @ljsalvatierra-factorlibre
Translated using Weblate (Croatian)
9952e62 
Currently translated at 75.0% (6 of 8 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_change_currency
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_change_currency/hr/
@hugho-ad @ljsalvatierra-factorlibre
[FIX] account_invoice_change_currency: Rounding price_unit & tax amou…
e766701 
…nt after convertions
@OCA-git-bot @ljsalvatierra-factorlibre
account_invoice_change_currency 12.0.1.1.0
77e09c5
@marylla @ljsalvatierra-factorlibre
Translated using Weblate (German)
d26e3bf 
Currently translated at 62.5% (5 of 8 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_change_currency
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_change_currency/de/
@Saran440 @ljsalvatierra-factorlibre
[IMP] account_invoice_change_currency: black, isort, prettier
2e61b84
@Saran440 @ljsalvatierra-factorlibre
[13.0][MIG] account_invoice_change_currency
a1ae702
@rolandojduartem @ljsalvatierra-factorlibre
[MIG] account_invoice_change_currency: Migration to 14.0
8cdbe7c 
**Changes**

Now, the account_invoice_change_currency avoid the mail tracking using account.move, res.currency
and new fields to handle the different calculations.

**New fields**

- original_currency_id: Store the base currency when the invoice is created or the conversion is called for the first time. This is used to calculate conversion from this currency.
- is_original_currency: Check if current currency is the base currency. This is used to hide custom rate field in the form view.
- original_price_unit: Store price unit from every line when the invoice is created or the conversion is called for the first time to use it to convert the amount in the new currency.

[UPD] README.rst
@rolandojduartem @ljsalvatierra-factorlibre
[MIG] account_invoice_change_currency: Migration to 15.0
22f9267
@OCA-git-bot @ljsalvatierra-factorlibre
[UPD] README.rst
3b6a1b2
@rolandojduartem @ljsalvatierra-factorlibre
[IMP] account_invoice_change_currency: Speed up module installation. (O…
d2ae3be 
…CA#1185)

Initializing column custom_rate on table account_move for the improvement in performance to avoid long duration in databases with thousand of moves using a hook.

account_invoice_change_currency 15.0.2.0.0
@ljsalvatierra-factorlibre
[UPD] Update account_invoice_change_currency.pot
5834b1c
@oca-transbot @ljsalvatierra-factorlibre
Update translation files
5fb9cdc 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoicing-15.0/account-invoicing-15.0-account_invoice_change_currency
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-15-0/account-invoicing-15-0-account_invoice_change_currency/
@jabelchi @ljsalvatierra-factorlibre
Added translation using Weblate (Catalan)
db5e9aa
@jabelchi @ljsalvatierra-factorlibre
Translated using Weblate (Catalan)
8f2b793 
Currently translated at 84.6% (11 of 13 strings)

Translation: account-invoicing-15.0/account-invoicing-15.0-account_invoice_change_currency
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-15-0/account-invoicing-15-0-account_invoice_change_currency/ca/
@ljsalvatierra-factorlibre
[MIG] account_invoice_change_currency: Migration to 16.0
3331af5
@ljsalvatierra-factorlibre ljsalvatierra-factorlibre force-pushed the 16.0-mig-account_invoice_change_currency branch from 59053e3 to 3331af5 Compare May 26, 2023 05:37
MayteGLC
MayteGLC approved these changes May 26, 2023
View reviewed changes
Copy link

@MayteGLC MayteGLC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review OK

https://www.awesomescreenshot.com/video/17763320?key=2ccee70e124bc26107e41576f93c13eb

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@RodrigoBM
Copy link

Functional review OK

https://www.awesomescreenshot.com/video/17763320?key=2ccee70e124bc26107e41576f93c13eb

FYI: @rafaelbn

rafaelbn
rafaelbn approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are awesome! ❤️

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1261-by-rafaelbn-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit bbf5c7b into OCA:16.0 May 26, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d399e0b. Thanks a lot for contributing to OCA. ❤️

@ljsalvatierra-factorlibre ljsalvatierra-factorlibre deleted the 16.0-mig-account_invoice_change_currency branch May 29, 2023 06:31
odooNextev pushed a commit to odooNextev/account-invoicing that referenced this pull request Sep 29, 2023
@OCA-git-bot
Merge PR OCA#1261 into 14.0
26f9443 
Signed-off-by kittiu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RodrigoBM RodrigoBM RodrigoBM approved these changes

@rafaelbn rafaelbn rafaelbn approved these changes

@AnizR AnizR AnizR approved these changes

@MayteGLC MayteGLC MayteGLC approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.

None yet