[16.0][MIG] sale_order_invoicing_grouping_criteria #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JavierIniesta
changed the title
|
/ocabot migration sale_order_invoicing_grouping_criteria |
|
We have done functional tests and it works correctly. |
|
Hi @JavierIniesta |
JavierIniesta
force-pushed
the
16.0-mig-sale_order_invoicing_grouping_criteria
branch
from
c4eecb3
to
ba59adb
Compare
|
Hi @rp-landoo I rebased |
|
This PR has the |
RodrigoBM
suggested changes
Jun 1, 2023
sale_order_invoicing_grouping_criteria/tests/test_sale_order_invoicing_group_criteria.py
Outdated
Show resolved
Hide resolved
…rouping criteria This module allows to use custom criteria for grouping sales orders to be invoiced. Default criteria for grouping (invoicing partner and currency used) will be always applied, as if not respected, there will be business inconsistencies, but you can add more fields to split the invoicing according them. Configuration ============= For creating new grouping criteria: 1. Go to *Invoicing > Configuration > Management > Invoicing Grouping Criteria*. 2. Create or modify existing criteria, selecting fields belonging to "Sales Order" header model for grouping according them. 3. Invoicing address and currency will always be applied with the selected ones. For setting a different grouping criteria for a specific customer: 1. Go to *Invoicing > Sales > Master Data > Customers*. 2. Open the desired customer. 3. Go to *Invoicing* page. 4. Set on "Sales Invoicing Grouping Criteria" the desired grouping criteria. For setting a different default grouping criteria than the standard for the whole company: 1. Go to *Invoicing > Configuration> Settings*. 2. Locate inside "Sales Order Invoicing" section, the field "Default Grouping Criteria". 3. Introduce there the grouping criteria to be applied by default. If empty, the general default of invoicing address + currency will be applied. Usage ===== 1. Go to *Sales > Invoicing > Orders to Invoice*. 2. Select sales orders whose invoicing you want to do. 3. Click on *Action > Invoice Order*. 4. Click on "Create and View Invoices" button. 5. On that moment, the grouping criteria will be applied, and you will see different invoices if the criteria doesn't match for them.
- Standard procedure - Adapt code
- Standard procedure - Adapt code
Odoo now includes a hook for obtaining the grouping criteria, so we are making use of it for cleaning some code and being compatible with other developments. We also clarifies in documentation the new company grouping criteria also introduced by Odoo, as v13 allows to see several companies at the same time.
…riteria, but slice super calls It turns out that the grouping criteria is applied over the invoice vals dictionary list instead on sales order so you can't group by any field in sales order, including the trick of slicing by ID for not grouping at all. We then restore and adapt the v12 code, that slices the recordset in pieces according the grouping criteria with fields obtained in the sales orders.
- The partner to get the grouping criteria should be the invoice address (if set) as this one will be used to create the invoice; - Extract this part into a function to have a overwritable point; - Little improvement into unit test: disable tracking.
The function signature has changed in 14.0
Currently translated at 100.0% (21 of 21 strings) Translation: account-invoicing-15.0/account-invoicing-15.0-sale_order_invoicing_grouping_criteria Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-15-0/account-invoicing-15-0-sale_order_invoicing_grouping_criteria/fr/
Currently translated at 100.0% (21 of 21 strings) Translation: account-invoicing-15.0/account-invoicing-15.0-sale_order_invoicing_grouping_criteria Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-15-0/account-invoicing-15-0-sale_order_invoicing_grouping_criteria/ca/
JavierIniesta
force-pushed
the
16.0-mig-sale_order_invoicing_grouping_criteria
branch
from
ba59adb
to
67d629c
Compare
RodrigoBM
approved these changes
Jun 2, 2023
|
This PR has the |
ljsalvatierra-factorlibre
approved these changes
Jun 2, 2023
|
is it possible to merge this PR? @OCA/accounting-maintainers |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 8f4ca2a. Thanks a lot for contributing to OCA. ❤️ |
odooNextev
pushed a commit
to odooNextev/account-invoicing
that referenced
this pull request
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.