-
-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][mig] account_invoice_force_number #1441
[16.0][mig] account_invoice_force_number #1441
Conversation
Hi @heliaktiv
|
@heliaktiv Runboat does not work. Can you enable it to check the module? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review done.
This addons works fine for me. However, it allows you to force numbers without limitation, you can take an invoice that already has a given number, pass it to draft and validate it again with a different new number.
The above can be legally problematic in certain countries... In my opinion I would add some [IMP]:
-
"Force number" visible only on OUT type invoices.
-
"Force number" visible only in certain invoices. Enable permission at journal.
Thanks for the contribution!
/ocabot migration account_invoice_force_number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@heliaktiv could you please address #1441 (comment) ? |
/ocabot rebase |
[FIX] module author [IMP] account_invoice_force_number does not work for supplier invoices
Congratulations, PR rebased to 16.0. |
58f799e
to
7d60897
Compare
[FIX] authors' position [REM] field name=type from views [FIX] xpath values in invoice_view.xml [FIX] PEP8 style [FIX] PEP8 style: lines too long
Update POT file and add FR translation More flexible xpath
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
…and apply OCA guidelines
Currently translated at 100.0% (3 of 3 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_force_number Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_force_number/it/
Currently translated at 100.0% (3 of 3 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_force_number Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_force_number/it/
Currently translated at 100.0% (3 of 3 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_force_number Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_force_number/it/
Currently translated at 100.0% (3 of 3 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_force_number Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_force_number/it/
Currently translated at 100.0% (3 of 3 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_force_number Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_force_number/gl/
Currently translated at 100.0% (3 of 3 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_force_number Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_force_number/es/
Currently translated at 100.0% (3 of 3 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_force_number Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_force_number/de/
Currently translated at 100.0% (3 of 3 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_force_number Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_force_number/pt_BR/
Currently translated at 100.0% (5 of 5 strings) Translation: account-invoicing-13.0/account-invoicing-13.0-account_invoice_force_number Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-13-0/account-invoicing-13-0-account_invoice_force_number/pt_BR/
Currently translated at 100.0% (5 of 5 strings) Translation: account-invoicing-14.0/account-invoicing-14.0-account_invoice_force_number Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-14-0/account-invoicing-14-0-account_invoice_force_number/sl/
7d60897
to
502c726
Compare
@JavierIniesta @heliaktiv I took care of squashing the administrative commits. Now the PR is ready to be merged. |
@SoniaViciana concerning #1441 (review) is a new feature request so please open a related issue. Thank you in advance. |
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 135346c. Thanks a lot for contributing to OCA. ❤️ |
No description provided.