Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][mig] account_invoice_force_number #1441

Merged
merged 39 commits into from
Sep 11, 2023

Conversation

heliaktiv
Copy link

No description provided.

@JavierIniesta
Copy link

Hi @heliaktiv
Please could you take into account this step from the migration wiki? (https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0)

@Gelo-fl
Copy link

Gelo-fl commented Aug 3, 2023

@heliaktiv Runboat does not work. Can you enable it to check the module?
Thanks in advance.

Copy link

@SoniaViciana SoniaViciana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review done.

This addons works fine for me. However, it allows you to force numbers without limitation, you can take an invoice that already has a given number, pass it to draft and validate it again with a different new number.

The above can be legally problematic in certain countries... In my opinion I would add some [IMP]:

  • "Force number" visible only on OUT type invoices.

  • "Force number" visible only in certain invoices. Enable permission at journal.

Thanks for the contribution!

@tafaRU
Copy link
Member

tafaRU commented Sep 5, 2023

/ocabot migration account_invoice_force_number

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Sep 5, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Sep 5, 2023
60 tasks
Copy link

@andreampiovesana andreampiovesana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tafaRU
Copy link
Member

tafaRU commented Sep 8, 2023

@heliaktiv could you please address #1441 (comment) ?

@tafaRU
Copy link
Member

tafaRU commented Sep 11, 2023

/ocabot rebase

@OCA OCA deleted a comment from OCA-git-bot Sep 11, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 16.0.

@OCA-git-bot OCA-git-bot force-pushed the 16.0-mig-account_invoice_force_number branch from 58f799e to 7d60897 Compare September 11, 2023 09:20
OpenCode and others added 20 commits September 11, 2023 11:25
Currently translated at 100.0% (3 of 3 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_force_number
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_force_number/it/
Currently translated at 100.0% (3 of 3 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_force_number
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_force_number/it/
Currently translated at 100.0% (3 of 3 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_force_number
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_force_number/it/
Currently translated at 100.0% (3 of 3 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_force_number
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_force_number/it/
Currently translated at 100.0% (3 of 3 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_force_number
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_force_number/gl/
Currently translated at 100.0% (3 of 3 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_force_number
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_force_number/es/
Currently translated at 100.0% (3 of 3 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_force_number
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_force_number/de/
Currently translated at 100.0% (3 of 3 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_force_number
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_force_number/pt_BR/
Currently translated at 100.0% (5 of 5 strings)

Translation: account-invoicing-13.0/account-invoicing-13.0-account_invoice_force_number
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-13-0/account-invoicing-13-0-account_invoice_force_number/pt_BR/
Currently translated at 100.0% (5 of 5 strings)

Translation: account-invoicing-14.0/account-invoicing-14.0-account_invoice_force_number
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-14-0/account-invoicing-14-0-account_invoice_force_number/sl/
@tafaRU tafaRU force-pushed the 16.0-mig-account_invoice_force_number branch from 7d60897 to 502c726 Compare September 11, 2023 09:25
@tafaRU
Copy link
Member

tafaRU commented Sep 11, 2023

@JavierIniesta @heliaktiv I took care of squashing the administrative commits. Now the PR is ready to be merged.

@tafaRU
Copy link
Member

tafaRU commented Sep 11, 2023

@SoniaViciana concerning #1441 (review) is a new feature request so please open a related issue. Thank you in advance.

@tafaRU
Copy link
Member

tafaRU commented Sep 11, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1441-by-tafaRU-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c56e8ab into OCA:16.0 Sep 11, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 135346c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet