[16.0][mig] sale_timesheet_invoice_description: Migration to 16.0 #1475

dsolanki-initos · 2023-06-08T12:13:03Z

No description provided.

victor-champonnois

Functionnal review OK

pedrobaeza · 2023-08-08T10:09:51Z

sale_timesheet_invoice_description/models/account_move.py


                timesheets = self.env["account.analytic.line"].sudo().search(domain)
                timesheets.write({"timesheet_invoice_line_id": aml.id})

-    def _check_balanced(self):
+    @contextmanager


Why adding this? And why we need to override this check in first place? Maybe the reason has gone or it should be implemented in other way.

It comes from this commit 98c253e . It looks like splitting the account move line by timesheet breaks the debit/credit balance by line.

I'm afraid I don't know account.move well enough to suggest a better way.

The new (in comparison to v15) @contextmanager here is needed, because the super method in the Odoo v16 core got one in the reworked accounting code, in commit odoo/odoo@d8d47f9.

However, the super call is implemented incorrectly here (a couple of lines below). It should read something line with super()._check_balanced(container): yield. The flake8-bugbear warning B901, suppressed here with # noqa, points to that issue.

👉 ~~I am fixing this.~~ [Update:] Fixed in 4e2d0ce.

pedrobaeza · 2023-08-08T10:10:28Z

sale_timesheet_invoice_description/readme/CONTRIBUTORS.rst

 * `Akretion <https://www.akretion.com>`_:

  * Clément Mombereau <clement.mombereau@akretion.com.br>
+  * Dhara Solanki <dhara.solanki@initos.com>


Incorrect indentation. This way, it's inside Akretion section.

👉 ~~I am fixing this.~~ [Update:] Fixed in 4e2d0ce.

Thank you for your advice.

Signed-off-by rafaelbn

tbaden · 2023-10-11T08:13:02Z

@dsolanki-initos can you have a look into the requested changes

[ADD] sale_timesheet_invoice_description: New module

There's a constraint that limits the quantity over received one. Although it seems invalid on services, we bypass it now with this.

Currently translated at 100,0% (10 of 10 strings) Translation: account-invoicing-11.0/account-invoicing-11.0-sale_timesheet_invoice_description Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-11-0/account-invoicing-11-0-sale_timesheet_invoice_description/de/

Keep the previous behavior showing only date Remove order parameter in sear method

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Currently translated at 100.0% (10 of 10 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-sale_timesheet_invoice_description Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-sale_timesheet_invoice_description/es/

Currently translated at 100.0% (10 of 10 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-sale_timesheet_invoice_description Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-sale_timesheet_invoice_description/de/

Currently translated at 100.0% (10 of 10 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-sale_timesheet_invoice_description Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-sale_timesheet_invoice_description/pt_BR/

Currently translated at 100.0% (10 of 10 strings) Translation: account-invoicing-14.0/account-invoicing-14.0-sale_timesheet_invoice_description Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-14-0/account-invoicing-14-0-sale_timesheet_invoice_description/es_AR/

azoellner · 2023-10-25T07:54:39Z

@pedrobaeza (@robinkeunen @tbaden) I now fixed the issues that you mentioned above, did run pre-commit afterwards, and finally rebased this feature branch onto the current head of its target "16.0".

pedrobaeza · 2023-10-25T08:22:46Z

Great, now it's available for reviewers. Check https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#review for knowing the process. You can review other PRs and ask in exchange that they review yours.

/ocabot migration sale_timesheet_invoice_description

azoellner · 2023-10-26T07:49:27Z

@pedrobaeza While working on migrating the feature "split-by-task" (see PR #1501 for version 15.0, which is still on my agenda), I found and fixed some issues related to version 16.0 core changes (to timesheets and accounting), pushed in fafcaef.

P.S. Note that the aforementioned PR #1501 does contain further fixes, unrelated to the migration itself. I did not include them here, as imho this migration branch should only be concerned with migrating the version 15.0 code, not fixing it.

robinkeunen

👍 Last 3 commits sould be squashed IMO.

Thx !

OCA-git-bot · 2023-10-26T10:32:33Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

* adapted code to version 16.0 changes; for details see below * added contributors * updated i18n: sale_timesheet_invoice_description.pot, de.po * run `pre-commit` Linking timesheets to invoice lines: Respecting both the specified (in context) start and end time, the same way as it is done for linking them to the invoice itself. Reworked preventing unbalanced invoice: Invoices must not and cannot be unbalanced. This is now (in 16.0) done automatically. I.e., the intermediate invoices, created while splitting lines, will no longer be possibly unbalanced.

azoellner · 2023-10-26T12:36:35Z

@robinkeunen I squashed the last three commits into one, as you suggested. Thx.

pedrobaeza · 2023-10-26T14:23:13Z

/ocabot merge nobump

OCA-git-bot · 2023-10-26T14:23:28Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1475-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2023-10-26T14:37:22Z

Congratulations, your PR was merged at 71edf5d. Thanks a lot for contributing to OCA. ❤️

dsolanki-initos force-pushed the 16.0-mig-sale_timesheet_invoice_description branch from e4cc071 to a880cd7 Compare June 9, 2023 10:42

victor-champonnois approved these changes Jul 19, 2023

View reviewed changes

pedrobaeza reviewed Aug 8, 2023

View reviewed changes

odooNextev pushed a commit to odooNextev/account-invoicing that referenced this pull request Sep 29, 2023

Merge PR OCA#1475 into 14.0

50193d9

Signed-off-by rafaelbn

carlosdauden and others added 25 commits October 24, 2023 16:55

[9.0][NEW] sale_timesheet_invoice_description: New module (OCA#154)

1180e9a

[ADD] sale_timesheet_invoice_description: New module

OCA Transbot updated translations from Transifex

2f6e901

[FIX] remove en.po that was erroneously created by transbot

230ffc4

OCA Transbot updated translations from Transifex

e287d42

[MIG] Make modules uninstallable

9cb06f5

[MIG] Rename manifest files

6586655

OCA Transbot updated translations from Transifex

9f164e2

[MIG] sale_timesheet_invoice_description: Migration to 10.0

7181a59

OCA Transbot updated translations from Transifex

42a86cd

[11.0][MIG] sale_timesheet_invoice_description: port to V11

0a60a1e

OCA Transbot updated translations from Transifex

3431a7b

[UPD] Update sale_timesheet_invoice_description.pot

69c44a2

[FIX] sale_timesheet_invoice_description: Load en_US language in tests

a7c908d

[FIX] sale_timesheet_invoice_description: Avoid new constraint

3c2149a

There's a constraint that limits the quantity over received one. Although it seems invalid on services, we bypass it now with this.

[MIG] sale_timesheet_invoice_description: Migration to 12.0

87cfe49

[MIG] sale_timesheet_invoice_description: Fix E261 flake8 error

0413730

[MIG] sale_timesheet_invoice_description: Improve code

974401f

Keep the previous behavior showing only date Remove order parameter in sear method

[UPD] Update sale_timesheet_invoice_description.pot

c0ff372

Update translation files

46febdc

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[ADD] icon.png

20db88a

[UPD] README.rst

7d00ba4

clementmbr and others added 8 commits October 24, 2023 16:55

[UPD] Readme

1a88922

[UPD] Update sale_timesheet_invoice_description.pot

09c296b

[IMP] sale_timesheet_invoice_description: black, isort, prettier

401d26e

[MIG] sale_timesheet_invoice_description: Migration to 15.0

ef71537

[UPD] Update sale_timesheet_invoice_description.pot

db0787c

[UPD] README.rst

fa77dfa

[IMP] sale_timesheet_invoice_description: pre-commit stuff

1685587

azoellner force-pushed the 16.0-mig-sale_timesheet_invoice_description branch from a880cd7 to 4e2d0ce Compare October 25, 2023 07:47

OCA-git-bot added this to the 16.0 milestone Oct 25, 2023

OCA-git-bot mentioned this pull request Oct 25, 2023

Migration to version 16.0 #1250

Open

60 tasks

robinkeunen approved these changes Oct 26, 2023

View reviewed changes

OCA-git-bot added approved ready to merge labels Oct 26, 2023

azoellner force-pushed the 16.0-mig-sale_timesheet_invoice_description branch from fafcaef to b419341 Compare October 26, 2023 12:34

azoellner mentioned this pull request Oct 26, 2023

[MIG] timesheet_invoice_description migration to 16.0 #1419

Closed

OCA-git-bot added the bot is merging ⏳ label Oct 26, 2023

OCA-git-bot merged commit 7e7b7fa into OCA:16.0 Oct 26, 2023
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Oct 26, 2023

azoellner deleted the 16.0-mig-sale_timesheet_invoice_description branch October 26, 2023 21:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][mig] sale_timesheet_invoice_description: Migration to 16.0 #1475

[16.0][mig] sale_timesheet_invoice_description: Migration to 16.0 #1475

dsolanki-initos commented Jun 8, 2023

victor-champonnois left a comment

pedrobaeza Aug 8, 2023

robinkeunen Oct 20, 2023

robinkeunen Oct 20, 2023

azoellner Oct 24, 2023 •

edited

pedrobaeza Aug 8, 2023

azoellner Oct 24, 2023 •

edited

tbaden commented Oct 11, 2023

azoellner commented Oct 25, 2023

pedrobaeza commented Oct 25, 2023 •

edited

azoellner commented Oct 26, 2023 •

edited

robinkeunen left a comment •

edited

OCA-git-bot commented Oct 26, 2023

azoellner commented Oct 26, 2023

pedrobaeza commented Oct 26, 2023

OCA-git-bot commented Oct 26, 2023

OCA-git-bot commented Oct 26, 2023

[16.0][mig] sale_timesheet_invoice_description: Migration to 16.0 #1475

[16.0][mig] sale_timesheet_invoice_description: Migration to 16.0 #1475

Conversation

dsolanki-initos commented Jun 8, 2023

victor-champonnois left a comment

Choose a reason for hiding this comment

pedrobaeza Aug 8, 2023

Choose a reason for hiding this comment

robinkeunen Oct 20, 2023

Choose a reason for hiding this comment

robinkeunen Oct 20, 2023

Choose a reason for hiding this comment

azoellner Oct 24, 2023 • edited

Choose a reason for hiding this comment

pedrobaeza Aug 8, 2023

Choose a reason for hiding this comment

azoellner Oct 24, 2023 • edited

Choose a reason for hiding this comment

tbaden commented Oct 11, 2023

azoellner commented Oct 25, 2023

pedrobaeza commented Oct 25, 2023 • edited

azoellner commented Oct 26, 2023 • edited

robinkeunen left a comment • edited

Choose a reason for hiding this comment

OCA-git-bot commented Oct 26, 2023

azoellner commented Oct 26, 2023

pedrobaeza commented Oct 26, 2023

OCA-git-bot commented Oct 26, 2023

OCA-git-bot commented Oct 26, 2023

azoellner Oct 24, 2023 •

edited

azoellner Oct 24, 2023 •

edited

pedrobaeza commented Oct 25, 2023 •

edited

azoellner commented Oct 26, 2023 •

edited

robinkeunen left a comment •

edited