Migration of account_invoice_blocking to 10.0 #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ADD] account_invoice_blocking
pedrobaeza
reviewed
Oct 17, 2016
| from openerp.tests.common import TransactionCase | ||
| from openerp import workflow | ||
| from odoo.tests.common import TransactionCase | ||
| from odoo import workflow |
Garamotte
reviewed
Oct 17, 2016
| _inherit = 'account.invoice' | ||
|
|
||
| @api.model | ||
| def _get_move_line(self, invoice): |
There was a problem hiding this comment.
Please convert this method from @api.model to @api.multi + self.ensure_one() without the self recordset argument, to follow standard changes since v10.
| ('invoice_id', '=', invoice.id)]) | ||
|
|
||
| @api.model | ||
| def _update_blocked(self, invoice, value): |
There was a problem hiding this comment.
Please convert this method from @api.model to @api.multi without the self recordset argument, to follow standard changes since v10.
rafaelbn
reviewed
Dec 6, 2016
|
|
||
| Usage | ||
| ===== | ||
|
|
There was a problem hiding this comment.
As better you describe how to use the module, as much more easier is to test it, so more people will be able to review it. It's just a recommendation. I rebuilding runbot for testing
adrienpeiffer
force-pushed
the
10-mig-account_invoice_blocking-ape
branch
from
e065573
to
6ad202d
Compare
|
@sylvain-garancher @rafaelbn Thanks for the review |
|
Travis error is unrelated #269 |
|
triggering a rebuild |
ThomasBinsfeld
approved these changes
Oct 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.