Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] add payment term rounding issue if balance #24

Merged
merged 2 commits into from Oct 21, 2014

Conversation

vrenaville
Copy link
Contributor

In case of a line of payment term set to balance none is return instead of the rounded value amount

@pedrobaeza
Copy link
Member

Please rebase your branch to enable automatic merge, and why are you rounding again the amount. I think that with only this line it's enough:

-amt = float_round(remaining_amount, precision_digits=prec)
+return float_round(remaining_amount, precision_digits=prec)

@vrenaville
Copy link
Contributor Author

Hello,
I did the mistake, two rounding is not useful ;) , i replace it in my last commit with just a return

@pedrobaeza
Copy link
Member

Rebase it's still needed. Please do it.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.23%) when pulling adbac64 on vrenaville:bug_payment_term_balance_case into 0cdd94b on OCA:7.0.

@pedrobaeza
Copy link
Member

Thanks 👍

@tafaRU
Copy link
Member

tafaRU commented Oct 21, 2014

👍

1 similar comment
@yvaucher
Copy link
Member

👍

yvaucher added a commit that referenced this pull request Oct 21, 2014
[FIX] add payment term rounding issue if balance
@yvaucher yvaucher merged commit c50d1a2 into OCA:7.0 Oct 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants