Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] Migration of account_invoice_merge_purchase to 10.0 #251

Merged

Conversation

adrienpeiffer
Copy link
Contributor

@adrienpeiffer adrienpeiffer commented Apr 3, 2017

@pedrobaeza
Copy link
Member

This has been recently migrated to 9.0, so little changes are needed from that version. Please respect commit history following migration guide: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-10.0

@adrienpeiffer adrienpeiffer force-pushed the 10.0-mig-account_invoice_merge_purchase-ape branch from 43867af to 4ea3691 Compare April 3, 2017 11:21
@adrienpeiffer
Copy link
Contributor Author

@pedrobaeza It's done.

Copy link

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicking.
Do you need the setup directory?

Merge invoices from purchase order
==================================

This module provides a compatibility between purchase order workflow and account invoice merge module
This module provides a compatibility between purchase order workflow and
account invoice merge module

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a period.



Usage
=====

Select several vendor bills from the same partner and click on **Merge Partner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use enumerated list ("#. ")

@@ -0,0 +1 @@
__import__('pkg_resources').declare_namespace(__name__)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you really need to have those files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes 😄

@pedrobaeza
Copy link
Member

Please check Travis

@pedrobaeza pedrobaeza mentioned this pull request Apr 3, 2017
34 tasks
@adrienpeiffer
Copy link
Contributor Author

@pedrobaeza Thanks. account_invoice merge is not yet merged.

@pedrobaeza
Copy link
Member

Yeah, that's right! OK, let's put this as WIP. You have already my code review approval anyway 😉

@MiquelRForgeFlow
Copy link
Contributor

@adrienpeiffer Can you update this PR, please?

@JordiBForgeFlow
Copy link
Sponsor Member

@adrienpeiffer Now that account_invoice merge there are now some errors in Travis.

@pedrobaeza
Copy link
Member

A rebase is needed in this PR

@adrienpeiffer adrienpeiffer force-pushed the 10.0-mig-account_invoice_merge_purchase-ape branch from 4ea3691 to 025fa96 Compare October 9, 2017 07:19
@adrienpeiffer
Copy link
Contributor Author

Rebased

@pedrobaeza
Copy link
Member

Travis is still failing. Do you know why?

Copy link
Contributor

@benwillig benwillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@LoisRForgeFlow
Copy link
Contributor

@adrienpeiffer Any update here? Tests are failing.

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests of this module are failing

@rousseldenis
Copy link
Sponsor Contributor

@aheficent I'm on it

@rousseldenis rousseldenis force-pushed the 10.0-mig-account_invoice_merge_purchase-ape branch from 025fa96 to 19c75f0 Compare July 10, 2018 17:01
@rousseldenis
Copy link
Sponsor Contributor

@aheficent Done. Waiting for travis 😅

@moylop260 moylop260 merged commit c9e98d8 into OCA:10.0 Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet