-
-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] Migration of account_invoice_merge_purchase to 10.0 #251
[MIG] Migration of account_invoice_merge_purchase to 10.0 #251
Conversation
adrienpeiffer
commented
Apr 3, 2017
•
edited
edited
- depends on [10.0][mig] account_invoice_merge #238
This has been recently migrated to 9.0, so little changes are needed from that version. Please respect commit history following migration guide: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-10.0 |
43867af
to
4ea3691
Compare
@pedrobaeza It's done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpicking.
Do you need the setup directory?
Merge invoices from purchase order | ||
================================== | ||
|
||
This module provides a compatibility between purchase order workflow and account invoice merge module | ||
This module provides a compatibility between purchase order workflow and | ||
account invoice merge module |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a period.
|
||
|
||
Usage | ||
===== | ||
|
||
Select several vendor bills from the same partner and click on **Merge Partner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use enumerated list ("#. ")
@@ -0,0 +1 @@ | |||
__import__('pkg_resources').declare_namespace(__name__) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you really need to have those files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes 😄
Please check Travis |
@pedrobaeza Thanks. account_invoice merge is not yet merged. |
Yeah, that's right! OK, let's put this as WIP. You have already my code review approval anyway 😉 |
@adrienpeiffer Can you update this PR, please? |
@adrienpeiffer Now that account_invoice merge there are now some errors in Travis. |
A rebase is needed in this PR |
4ea3691
to
025fa96
Compare
Rebased |
Travis is still failing. Do you know why? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@adrienpeiffer Any update here? Tests are failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests of this module are failing
@aheficent I'm on it |
025fa96
to
19c75f0
Compare
@aheficent Done. Waiting for travis 😅 |