[11.0][MIG] account_invoice_merge

[ValentinVinagre]

Finished the PR #365 from @ adrian-pesol

[pedrobaeza]

I try to avoid the use of this module. Why do you need it?

[ValentinVinagre]

Hello @pedrobaeza,
I need this module to do a joint billing when the client needs it.
Odoo 11.0 does not provide this feature, right?

[pedrobaeza]

No, but why do you need it? If you need to merge invoices, it's because a previous flow is maybe not adjusted. (NOTE: I'm trying to avoid you problems with this module as it needs a lot of extensions depending on other installed modules).

[tuomoaura]

@pedrobaeza eCommerse solution is feeding separate sales orders to be invoiced once a month (all invoices for larger customers are merged into one). And send automatically. How would you do this without merge module?

[RoelAdriaans]

With Odoo 11.0 you can combine the sale orders for invoicing, this works without a problem.
Issues come if you have multiple sources of the invoices.

Notable examples are the contract module and point of sale module.
Valid Use case, we have a client that sells products via the point of sale. Mostly business to consumer, but also some business to business. They don't have to pay at the till but get an invoice. Because handling a lot of invoices for just a few euro's is costly, we merge them at the end of the month and send it as a combined invoice. Other clients are invoiced at the end of the business day, or when there is a sufficient amount to invoice.
These are all manual actions, and difficult to automate because it can change every week.. :)

[elicoidal]

Good to see that this module is surviving the years 😉
Mostly details, no functional test yet

[pedrobaeza]

@tuomoaura you got the answer in the previous comment

@RoelAdriaans for contract module, we have develop several things for combining everything in one invoice:

• https://github.com/OCA/contract/tree/11.0/contract_sale_invoicing allows to invoice pending sales orders.
• Main module has a hook through an argument for adding to an existing invoice:

https://github.com/OCA/contract/blob/5d5387e0eda83163aec2d874bfb84cde4a651e70/contract/models/account_analytic_account.py#L264

• On v9, we developed a module for joining several contracts for same partner:

https://github.com/OCA/contract/tree/9.0/contract_invoice_merge_by_partner

In summary, it's better to unify all the invoice creation handling in one side, instead of fighting with invoice creation issues from contract and from merging invoices from other sources.

For POS, I think a better solution can be to invoice all POS sales orders together. It seems that this is more work, but doing this way, you control better which data should be put in invoices instead of delegating this in generic merge methods.

What do you think?

[MiquelRForgeFlow]

I miss the commit history of the account_invoice_merge.

[HaraldPanten]

I think that this module is not so useful for customer invoices, maybe. In V11, users can invoice several sale orders together as @RoelAdriaans said before.

Even though, it would allow extra functionalities for vendor bills, right?

I don't know any kind of "purchase order combination for invoicing" action. Do you? @pedrobaeza @ValentinVinagre @tuomoaura

[ValentinVinagre]

Hi @HaraldPanten,
I see good idea develop the "purchase order combination for invoicing" action (the same thing that odoo provides with SO), if with this action and other modules we can group all type of invoicings.

[pedrobaeza]

You can add several purchase orders to one invoice using the purchase order field, or even migrate this module for mass invoicing ala sales part: https://github.com/OCA/account-invoicing/tree/9.0/purchase_batch_invoicing

[ValentinVinagre]

The module 'purchase_batch_invoicing' covers our need, but the community need the 'account_invoice_merge'? Because with what you said with other modules and standard we can 'cover' the functionalities of this module.

[pedrobaeza]

I'm trying to push everyone for finding alternatives, but if you have already migrated the module and want to finish the PR...

[HaraldPanten]

account_invoice_merge allows the functionallity for merging common invoice lines as well. I think that user can't do it with the base order combination for invoicing action, right?

That's an important feature from my point of view.

What do you think? @ValentinVinagre @pedrobaeza

[pedrobaeza]

@HaraldPanten please read above comments where I said my PoV of this not being needed at all.

[ValentinVinagre]

@HaraldPanten It's a characteristic to keep in mind.

[cvinh]

We also use this module in the following Use case :

• we return goods coming from several purchase order to supplier and make the corresponding credit notes according to eash initial purchase order
• the supplier sends us only one credit note including all the returning goods
  So we have to merge our credit notes

[eduardgm]

@elicoidal What do you think about the last commit? Is it all correct?

[pedrobaeza]

Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-11.0

[HaraldPanten]

Hi all,

Is it ready to merge?

THX!

[nikul-serpentcs]

Small Change

[aidiss]

Will this ever be merged? :)

[LoisRForgeFlow]

@aidiss Seems that there are a bunch of things @ValentinVinagre has to take care of yet:

• Attend reviews.
• Attend CI checks: both travis and runbot are red.
• Preserve and clean commit history properly.

[pedrobaeza]

@aidiss you can contribute also instead of ranting.

[ValentinVinagre]

Hello, I will check the errors during this week.

[Tomaskarpovic]

@ValentinVinagre, might be time saver for you to fix this error: ValueError: malformed node or string: <_ast.BoolOp object at 0x7f32d2a780b8> from here: https://travis-ci.org/OCA/account-invoicing/jobs/432816208. Just don't use or in manifest here:

account-invoicing/account_invoice_merge/__manifest__.py

Line 14 in ac37ee8

'website': "https://github.com/OCA/<repo>" or "https://github.com/OCA/<repo>/tree/<branch>/<addon>",

[aidiss]

@aidiss you can contribute also instead of ranting.

@pedrobaeza I was trying to express interest in PR. Please do not consider my message to be a rant. Unfortunately, I do not have skills to contribute, but I do respect the work @ValentinVinagre is doing. 💯

[JordiBForgeFlow]

@tuomoaura

@pedrobaeza eCommerse solution is feeding separate sales orders to be invoiced once a month (all invoices for larger customers are merged into one). And send automatically. How would you do this without merge module?
The following modules would allow you to achieve the option to invoice on a monthly basis:
https://github.com/OCA/sale-workflow/tree/11.0/sale_invoice_group_method
https://github.com/OCA/sale-workflow/tree/11.0/sale_merge_draft_invoice

[bjeficent]

Hi @ValentinVinagre
Are you planning to keep working on this?

[alvaro-domatix]

Hi, what's the status of this PR?
Even if it stills open, is there any intention to keep working on it or merge it?
@ValentinVinagre @pedrobaeza

[ValentinVinagre]

Hi @alvaro-domatix ,
I don't plan to finish one PR that has been open for almost 2 years, but you can end it if you want.