Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] Add accout invoice merge payment module #60

Merged
merged 8 commits into from
Jul 15, 2015

Conversation

adrienpeiffer
Copy link
Contributor

Add accout invoice merge payment module that was written to extend the functionality of Account Invoice Merge module to support fields added in Account Payment Partner from OCA/bank-payment.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.72%) to 26.17% when pulling 63bf9ae on acsone:8.0-add-accout-invoice-merge-payment-ape into db58839 on OCA:8.0.

'account_invoice_merge',
'account_payment_partner',
],
'data': [],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to remove empty section.

@sbidoul
Copy link
Member

sbidoul commented Mar 30, 2015

A small remark in README, otherwise 👍

@Cedric-Pigeon
Copy link

A small remark in manifest, otherwise 👍

@adrienpeiffer
Copy link
Contributor Author

@sbidoul @Cedric-Pigeon Thanks for your reviews

@sbidoul
Copy link
Member

sbidoul commented Apr 21, 2015

This module is important to make the account_invoice_merge work correctly without losing data in presence of OCA/bank-payment modules. As it does not add functionality but merly make thing work correctly it auto-installs when it's dependencies are installed.

👍 (code review and functional test)

@@ -0,0 +1,32 @@
Account Invoice Merge Payment
Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

licence badge missing

.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg
    :alt: License AGPL-3

@lmignon
Copy link
Sponsor Contributor

lmignon commented Apr 21, 2015

A small remark in README, otherwise :+1: (code review)

@adrienpeiffer
Copy link
Contributor Author

@lmignon I added the badge. Thanks !

@coveralls
Copy link

Coverage Status

Coverage increased (+12.08%) to 37.52% when pulling 487aef2 on acsone:8.0-add-accout-invoice-merge-payment-ape into db58839 on OCA:8.0.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+12.08%) to 37.52% when pulling 487aef2 on acsone:8.0-add-accout-invoice-merge-payment-ape into db58839 on OCA:8.0.

@lmignon
Copy link
Sponsor Contributor

lmignon commented May 7, 2015

@adrienpeiffer Thank you 👍

@sbidoul
Copy link
Member

sbidoul commented Jun 8, 2015

@adrienpeiffer can you rebase (confllict in travis.yml)?

@adrienpeiffer adrienpeiffer force-pushed the 8.0-add-accout-invoice-merge-payment-ape branch from 487aef2 to d7abb21 Compare June 8, 2015 08:18
@adrienpeiffer
Copy link
Contributor Author

@sbidoul It's done !

@sbidoul
Copy link
Member

sbidoul commented Jun 29, 2015

I added OCA/bank-payment to runbot and restarted the build.

@adrienpeiffer
Copy link
Contributor Author

Thanks @sbidoul. Now CI are green !

@adrienpeiffer
Copy link
Contributor Author

I think this one is ready to merge

hbrunn added a commit that referenced this pull request Jul 15, 2015
…nt-ape

[8.0] Add accout invoice merge payment module
@hbrunn hbrunn merged commit edfe5ee into OCA:8.0 Jul 15, 2015
@sbidoul sbidoul deleted the 8.0-add-accout-invoice-merge-payment-ape branch September 9, 2015 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants