-
-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.0] Add accout invoice merge payment module #60
[8.0] Add accout invoice merge payment module #60
Conversation
'account_invoice_merge', | ||
'account_payment_partner', | ||
], | ||
'data': [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to remove empty section.
A small remark in README, otherwise 👍 |
A small remark in manifest, otherwise 👍 |
@sbidoul @Cedric-Pigeon Thanks for your reviews |
This module is important to make the account_invoice_merge work correctly without losing data in presence of OCA/bank-payment modules. As it does not add functionality but merly make thing work correctly it auto-installs when it's dependencies are installed. 👍 (code review and functional test) |
@@ -0,0 +1,32 @@ | |||
Account Invoice Merge Payment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
licence badge missing
.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg
:alt: License AGPL-3
A small remark in README, otherwise :+1: (code review) |
@lmignon I added the badge. Thanks ! |
1 similar comment
@adrienpeiffer Thank you 👍 |
@adrienpeiffer can you rebase (confllict in travis.yml)? |
487aef2
to
d7abb21
Compare
@sbidoul It's done ! |
I added OCA/bank-payment to runbot and restarted the build. |
Thanks @sbidoul. Now CI are green ! |
I think this one is ready to merge |
…nt-ape [8.0] Add accout invoice merge payment module
Add accout invoice merge payment module that was written to extend the functionality of Account Invoice Merge module to support fields added in Account Payment Partner from OCA/bank-payment.