Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] account_invoice_tax_note #648

Closed

Conversation

kongrattapong
Copy link
Contributor

No description provided.

@pedrobaeza pedrobaeza added this to the 13.0 milestone Dec 16, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 16, 2019
32 tasks
@kongrattapong kongrattapong changed the title [13.0][MIG][WIP] account invoice tax note [13.0][MIG] account_invoice_tax_note Dec 16, 2019
Copy link

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review. LGTM 👍

Copy link

@jarroyomorales jarroyomorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review and it's working as expected!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Contributor

@anasuarez1 anasuarez1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review LGTM!

Since everything looks ok can we get this merged?

@etobella
Copy link
Member

etobella commented May 6, 2021

@OCA/accounting-maintainers can this be merged?

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kongrattapong sorry for being picky, but can you please amend the commit message? something like [13.0][MIG] account_invoice_tax_note would be fine

@albariera
Copy link
Contributor

Superseeding as the author is not answering

@AaronHForgeFlow
Copy link
Contributor

Superseded by #930 Thanks for collaborate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet