-
-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration of account_invoice_line_description #71
Conversation
Please take the ocassion to rename it to account_invoice_line_description |
@pedrobaeza done. |
product | ||
and product.description | ||
and 'value' in res | ||
product and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can omit this condition
@pedrobaeza I addressed your remark in my last commit. Thanks! |
self, cr, uid, ids, product_id, uom_id, qty=0, | ||
name='', type='out_invoice', partner_id=False, fposition_id=False, | ||
price_unit=False, currency_id=False, context=None, company_id=None | ||
self, product, uom_id, qty=0, name='', type='out_invoice', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well spotted the change of the argument names!
👍 |
Wrong button! |
'invoice_line_description.' | ||
'group_use_product_description_per_inv_line') | ||
if ref: | ||
group_id = ref.id | ||
if group_id in user_groups: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment than https://github.com/OCA/account-invoicing/pull/72/files#r29494011
@guewen I addressed your comment, thanks! |
👍 thanks |
Migration of account_invoice_line_description
No description provided.