[12.0][FIX] account_payment_term_extension: consider day_of_the_month in compute()

[TimLai125]

Odoo standard logic in the compute() of the account.payment.term considers Terms' day_of_the_month.
https://github.com/odoo/odoo/blob/6ed05368ab616aa6b256898bcef35fac93dcbb54/addons/account/models/account_invoice.py#L2067-L2069

As account_payment_term_extension overwrites the compute() of the account.payment.term and day_of_the_month is no long being considered in the overwritten method. Hence this PR is trying to keep the compute() consistent with standard logic.

[yostashiro]

LGTM ;)

This fix makes it possible for us to handle a payment term such as "The end of month after next".

[pedrobaeza]

Please check Travis

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[pedrobaeza]

Please add a test exercising the new addition

[yostashiro]

Suggested change

	if line.day_of_the_month > 0:
	months_delta = (line.day_of_the_month < next_date.day) and 1 or 0
	next_date += relativedelta(
	day=line.day_of_the_month, months=months_delta)
	if line.day_of_the_month > 0:
	months_delta = (line.months == 0) and (line.day_of_the_month < next_date.day) and 1 or 0
	next_date += relativedelta(
	day=line.day_of_the_month, months=months_delta)

On second thought, we should bypass the standard month_delta logic when line.months is set, since the delta for line.months is already taken care of in the previous step.

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.