Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration of account_invoice_line_no_picking_name #72

Closed
wants to merge 11 commits into from

Conversation

tafaRU
Copy link
Member

@tafaRU tafaRU commented Apr 29, 2015

No description provided.

@tafaRU tafaRU added the 8.0 label Apr 29, 2015
@pedrobaeza pedrobaeza changed the title Migration of invoice_line_no_picking_name Migration of account_invoice_line_no_picking_name Apr 29, 2015
@pedrobaeza
Copy link
Member

👍

You can add OCA's logo for completion.

@tafaRU tafaRU force-pushed the 8.0-invoice_line_no_picking_name-migr branch from 4b6ea39 to a502268 Compare April 30, 2015 10:22
@coveralls
Copy link

Coverage Status

Coverage increased (+1.93%) to 38.52% when pulling a502268 on tafaRU:8.0-invoice_line_no_picking_name-migr into 3617499 on OCA:8.0.

)
if ref and len(ref) > 1 and ref[1]:
group_id = ref[1]
if group_id in user_groups:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use self.user_has_groups(cr, uid, 'account_invoice_line_no_picking_name.group_not_use_picking_name_per_invoice_line', context=context (see https://github.com/odoo/odoo/blob/8.0/openerp/models.py#L1363-L1374). It calls ResUsers.has_groups() which uses a cache for the result.

@tafaRU
Copy link
Member Author

tafaRU commented May 5, 2015

@guewen just applied your tip, very useful, thanks!

@coveralls
Copy link

Coverage Status

Coverage increased (+1.35%) to 37.94% when pulling 47f22e5 on tafaRU:8.0-invoice_line_no_picking_name-migr into 3617499 on OCA:8.0.

@eLBati
Copy link
Member

eLBati commented May 6, 2015

👍

@tafaRU
Copy link
Member Author

tafaRU commented May 25, 2015

@guewen could you please check if PR looks good now?

Thank you in advance.

'group_not_use_picking_name_per_invoice_line',
context=context
):
res['name'] = move.name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This key and this value isn't already present in res ?
https://github.com/odoo/odoo/blob/8.0/addons/stock_account/stock.py#L158

@pedrobaeza
Copy link
Member

@tafaRU, any news about this?

@tafaRU
Copy link
Member Author

tafaRU commented Sep 25, 2015

@adrienpeiffer, you're right so this module is superfluous since 8.0.
I close this PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants