Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.0 account voucher no auto lines #13

Merged
merged 3 commits into from Mar 17, 2015

Conversation

joaoalf
Copy link

@joaoalf joaoalf commented Oct 28, 2014

This module changes the voucher behavior to allow users to manually select the lines that will be payed.

@pedrobaeza
Copy link
Member

Good solution. 👍

Tests will be much appreciated, at even more with this hacky solution.

@joaoalf
Copy link
Author

joaoalf commented Oct 28, 2014

Thanks for the comments @pedrobaeza

What kind of test do you have in mind? I ask because since the onchange methods are made to affect the client behavior and not the server, to test if I'm still able to create a voucher won't prove much and to test if the onchange returns the right struct sounds too trivial. It would be nice to have real client side tests to validate the onchange behaviour but so far the client side tests features of Odoo are too obscure to be trusted.

@pedrobaeza
Copy link
Member

Well, although a simple test like create an account invoice, then an account voucher, and check if the amount is 0, this can very useful when migrating this to future versions. YAML tests trigger onchange automatically, so there's no problem with that.

@max3903 max3903 modified the milestone: 7.0 Feb 19, 2015
@joaoalf joaoalf merged commit 7431579 into OCA:7.0 Mar 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants