[11.0][MIG] account_payment_return #176

luismontalba · 2018-03-23T18:06:17Z

Returned Customers Payment Orders

This module implements customer receivables returns and allows to send
related reconciled account move lines back to a state where the debt is still
open, and letting history of it.

Usage

Go to Invoicing > Sales > Customer Payment Returns, and create a new
record, register on each line a paid (reconciled) receivable journal item,
and input the amount that is going to be returned.
Another option to fill info is setting references and click match button to
find matches with invoices, move lines or moves. This functionality is extended
by other modules as account_payment_return_import_sepa_pain
Next, press button "Confirm" to create a new move line that removes the
balance from the bank journal and reconcile items together to show payment
history through it.
After confirmation you can access from the payment form view to the move
created.

cc @Tecnativa

…payments.

[IMP] account_payment_return: Implement find match with reference field

When entering manually returns, you need to change the line date. This commit also allows to use header date as defaut line date.

* For journal entry dictionary. * For extra return lines.

)

elicoidal

some details.
LGTM no test

elicoidal · 2018-03-24T01:22:27Z

account_payment_return/README.rst

+Usage
+=====
+
+Go to Invoicing > Sales > Customer Payment Returns, and create a new


Please create enumerated list

elicoidal · 2018-03-24T01:22:46Z

account_payment_return/README.rst

+record, register on each line a paid (reconciled) receivable journal item,
+and input the amount that is going to be returned.
+
+Another option to fill info is setting references and click match button to


same here: it increases visibility

elicoidal · 2018-03-24T01:24:38Z

account_payment_return/models/__init__.py

@@ -0,0 +1,8 @@
+# -*- coding: utf-8 -*-


remove coding in all files (python 3)
Remove copyright info in all init.py files

elicoidal · 2018-03-24T01:26:05Z

account_payment_return/models/account_journal.py

+    _inherit = "account.journal"
+
+    default_expense_account_id = fields.Many2one(
+        comodel_name='account.account', string='Default Expense Account',


string is not consistent with help.
I suggest "Default Commission Account"

Commission is more for sales terminology. I don't think it's correct for an expense.

elicoidal · 2018-03-24T01:26:14Z

account_payment_return/models/account_journal.py

+        comodel_name='account.account', string='Default Expense Account',
+        help='Default account for commission expenses')
+    default_expense_partner_id = fields.Many2one(
+        comodel_name="res.partner", string="Default Expense Partner",


elicoidal · 2018-03-24T01:27:55Z

account_payment_return/models/payment_return.py

+                    append_error(line)
+        if error_list:
+            raise UserError(
+                _("Payment reference must be unique!"


pedrobaeza · 2018-03-24T12:49:32Z

account_check_printing_report_base/tests/test_check_printing_report.py

@@ -135,4 +135,4 @@ def test_check_printing_with_layout(self):
            payment.print_checks()
        except UserError as e:
            pass
-        self.assertEquals(e, False)
+        self.assertEqual(e, False)


Why changing this?

Well, it's changed when you run 2to3 -wnj4 --no-diffs . as suggested here:
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-11.0

Yeah, but you must run it not on the entire repository, but on your module folder.

You are right, it was a mistake, I'll fix it

pedrobaeza · 2018-03-26T09:14:58Z

account_payment_return/README.rst

-Go to Invoicing > Sales > Customer Payment Returns, and create a new
-record, register on each line a paid (reconciled) receivable journal item,
-and input the amount that is going to be returned.
+1. Go to Invoicing > Sales > Customer Payment Returns, and create a new


You don't need to put manually numbers. Putting #. , numbers are auto-assigned on rendering.

Changes done

pedrobaeza · 2018-03-26T09:15:43Z

account_payment_return/models/account_journal.py

@@ -9,9 +8,9 @@ class AccountJournal(models.Model):
    _inherit = "account.journal"

    default_expense_account_id = fields.Many2one(
-        comodel_name='account.account', string='Default Expense Account',
+        comodel_name='account.account', string='Default Commission Account',


Why changing this? Commission is more for sales, not for the meaning we are thinking (comisión).

I think both terms, bank expenses an bank commissions are right, I changed it because @elicoidal suggested it and I suppose he has better feeling than me about the best term in English language.

@pedrobaeza @luismontalba I suggested commission instead of expense to avoid the confusion with standard Odoo expense account.
Alternative would Charges (this is what appears in my bank statement) or Fees

I like Charges!

OK, I'll put Charges, It's a good option

luismontalba · 2018-03-27T11:27:04Z

Changes done

pedrobaeza · 2018-03-27T11:30:48Z

account_payment_return/models/account_journal.py

@@ -8,9 +8,9 @@ class AccountJournal(models.Model):
    _inherit = "account.journal"

    default_expense_account_id = fields.Many2one(
-        comodel_name='account.account', string='Default Commission Account',
-        help='Default account for commission expenses')
+        comodel_name='account.account', string='Default Charge Account',


It should be in plural.

pedrobaeza · 2018-03-27T11:31:19Z

account_payment_return/i18n/es.po

-msgid "Default Commission Partner"
-msgstr "Empresa por defecto para comisiones"
+msgid "Default Charge Partner"
+msgstr "Empresa del cargo por defecto"


Don't change the previous translation, although the source term changes.

pedrobaeza

Please also change the source term in all current translations

luismontalba · 2018-04-04T17:46:09Z

Changes done

sergio-teruel and others added 11 commits March 22, 2018 21:12

account_payment_return: This module implements the return of invoice …

f40f699

…payments.

account_payment_return: Improve behaviour

159ee56

account_payment_return: Implement find match with reference field (#2)

4e6d43f

[IMP] account_payment_return: Implement find match with reference field

OCA Transbot updated translations from Transifex

777a761

account_payment_return: Improvements to suite (OCA#107)

98c8d7c

account_payment_return: Migrate 8.0 to 9.0

ec5ce1f

account_payment_return: Make line date editable

c3d0ad0

When entering manually returns, you need to change the line date. This commit also allows to use header date as defaut line date.

account_payment_retun: Add hooks

5b3abfe

* For journal entry dictionary. * For extra return lines.

account_payment_return: Period not present in 9.0

1b5750a

[MIG] account_payment_return: Migration to 10.0

e7fdd23

[IMP] account_payment_return: Add return expenses functionality (OCA#156

1cf8b14

)

luismontalba changed the title ~~[11.0][MIG] account payment return~~ [11.0][MIG] account_payment_return Mar 23, 2018

elicoidal added the needs review label Mar 24, 2018

elicoidal added this to the 11.0 milestone Mar 24, 2018

elicoidal approved these changes Mar 24, 2018

View reviewed changes

pedrobaeza reviewed Mar 24, 2018

View reviewed changes

pedrobaeza reviewed Mar 26, 2018

View reviewed changes

luismontalba force-pushed the 11.0-mig-account_payment_return branch from 46cca32 to 4919169 Compare March 27, 2018 10:53

pedrobaeza reviewed Mar 27, 2018

View reviewed changes

pedrobaeza requested changes Mar 27, 2018

View reviewed changes

luismontalba force-pushed the 11.0-mig-account_payment_return branch from 5330d41 to a7c8446 Compare April 4, 2018 16:56

luismontalba mentioned this pull request Apr 5, 2018

[11.0][mig] account_payment_return_import #178

Merged

pedrobaeza approved these changes Apr 5, 2018

View reviewed changes

[11.0][MIG] account_payment_return

981d616

pedrobaeza force-pushed the 11.0-mig-account_payment_return branch from a7c8446 to 981d616 Compare April 5, 2018 09:26

pedrobaeza merged commit d4aa1df into OCA:11.0 Apr 5, 2018

pedrobaeza deleted the 11.0-mig-account_payment_return branch April 5, 2018 09:58

pedrobaeza mentioned this pull request Apr 5, 2018

Migration to version 11.0 #161

Closed

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[11.0][MIG] account_payment_return #176

[11.0][MIG] account_payment_return #176

luismontalba commented Mar 23, 2018

elicoidal left a comment

elicoidal Mar 24, 2018

elicoidal Mar 24, 2018

elicoidal Mar 24, 2018

elicoidal Mar 24, 2018

pedrobaeza Mar 26, 2018

elicoidal Mar 24, 2018

elicoidal Mar 24, 2018

pedrobaeza Mar 24, 2018

luismontalba Mar 26, 2018

pedrobaeza Mar 26, 2018

pedrobaeza Mar 26, 2018

luismontalba Mar 26, 2018

pedrobaeza Mar 26, 2018

luismontalba Mar 26, 2018

pedrobaeza Mar 26, 2018

luismontalba Mar 26, 2018

elicoidal Mar 26, 2018

pedrobaeza Mar 26, 2018

luismontalba Mar 27, 2018

luismontalba commented Mar 27, 2018

pedrobaeza Mar 27, 2018

pedrobaeza Mar 27, 2018

pedrobaeza left a comment

luismontalba commented Apr 4, 2018

[11.0][MIG] account_payment_return #176

[11.0][MIG] account_payment_return #176

Conversation

luismontalba commented Mar 23, 2018

Returned Customers Payment Orders

Usage

elicoidal left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luismontalba commented Mar 27, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza left a comment

Choose a reason for hiding this comment

luismontalba commented Apr 4, 2018