[11.0][account_partner_reconcile] splits the button 'Match payments' to 'Match Receivables' and 'Match payables' #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiquelRForgeFlow
suggested changes
Feb 5, 2019
| if reconcile_mode == 'customers': | ||
| accounts = self.property_account_receivable_id | ||
| else: | ||
| accounts = self.self.property_account_payable_id |
There was a problem hiding this comment.
It's Simplify, No need to else
accounts = self.property_account_payable_id
if reconcile_mode == 'customers':
accounts = self.property_account_receivable_id
| if reconcile_mode == 'customers': | ||
| accounts = self.property_account_receivable_id | ||
| else: | ||
| accounts = self.self.property_account_payable_id |
There was a problem hiding this comment.
It's Simplify, No need to else
accounts = self.property_account_payable_id
if reconcile_mode == 'customers':
accounts = self.property_account_receivable_id
MiquelRForgeFlow
force-pushed
the
11.0-account_partner_reconcile-fix-buttons
branch
from
295d45c
to
681859f
Compare
Splits the button 'Match payments' to 'Match Receivables' and 'Match Payables', as the previous button was just now working.
MiquelRForgeFlow
force-pushed
the
11.0-account_partner_reconcile-fix-buttons
branch
from
681859f
to
2830a05
Compare
|
@pedrobaeza ready to merge 🍏 |
LoisRForgeFlow
approved these changes
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous button was just now working in v11.