[12.0] [ADD] Payment Return Import SEPA: reason additional info #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
reviewed
Feb 26, 2019
There was a problem hiding this comment.
My only concern here is the length of the label of the new field, as it will take a lot of space in the tree. Can we look for a shorter label (maybe put a shorter one in the string of the XML?).
It's also curious that you add the field in the SEPA, but doesn't test for the value in the tests.
New free text field on return lines: additional information on return reason. This field is populated in account_payment_return_import_sepa_pain with the content of the AddtlInf tag. This is useful when the return reason code is NARR, meaning the reason description does not match any known code but is in this tag.
ThomasBinsfeld
force-pushed
the
12.0-add_payment_Return_import_sepa_pain_reason_add_info_tbi
branch
from
e08b369
to
0f7ce86
Compare
|
@pedrobaeza I fixed the test and changed the label (it fits on one line now). |
pedrobaeza
approved these changes
Feb 26, 2019
sbidoul
approved these changes
Feb 27, 2019
sbidoul
deleted the
12.0-add_payment_Return_import_sepa_pain_reason_add_info_tbi
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New free text field on return lines: additional information on return reason.
This field is populated in account_payment_return_import_sepa_pain with the content of the AddtlInf tag.
This is useful when the return reason code is NARR, meaning the reason description does not match any known code but is in this tag.
From #227