Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][MIG] account_partner_reconcile #239

Merged
merged 6 commits into from
Apr 21, 2019
Merged

[12.0][MIG] account_partner_reconcile #239

merged 6 commits into from
Apr 21, 2019

Conversation

MiquelRForgeFlow
Copy link
Contributor

Standard migration.

luismontalba
luismontalba reviewed Mar 28, 2019
View reviewed changes
account_partner_reconcile/readme/CONFIGURE.rst
@@ -0,0 +1,2 @@
The button is visible only to users that belong to the accounting groups
"Accountant" or "Adviser".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Billing" or "Billing Manager". To carry out the matching, users need to have activated the check "Show Full Accounting Features".

luismontalba
luismontalba approved these changes Mar 28, 2019
View reviewed changes
Copy link
Member

@luismontalba luismontalba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runbot, working fine, minor changes proposed in README

tbaden
tbaden approved these changes Apr 21, 2019
View reviewed changes
account_partner_reconcile/views/res_partner_view.xml
<?xml version="1.0" encoding="utf-8"?>
<odoo>

<record id="res_partner_view_buttons" model="ir.ui.view">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cosmetical change: use original id (not relevant for approvement)

prefer naming the inherited view after the original over using a name which follows the guidelines.

<record id="original_id" model="ir.ui.view">
    <field name="inherit_id" ref="original_module.original_id"/>

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

1 similar comment
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza merged commit 9ba96f0 into OCA:12.0 Apr 21, 2019
@emagdalenaC2i
Copy link
Contributor

@pedrobaeza Please. take a look at https://github.com/OCA/account-reconcile/tree/12.0/account_partner_reconcile

I think this module is already migrated and merged in /OCA/account-reconcile

@emagdalenaC2i
Copy link
Contributor

@mreficent Please, confirm if this PR is the same as the one in /OCA/account-reconcile
https://github.com/OCA/account-reconcile/tree/12.0/account_partner_reconcile

As you can see in #201 is moved and already merged

@pedrobaeza
Copy link
Member

Right, I have removed it from this repo in 7da0e3d

@MiquelRForgeFlow MiquelRForgeFlow deleted the 12.0-mig-account_partner_reconcile branch April 23, 2019 09:25
@MiquelRForgeFlow
Copy link
Contributor Author

Oh my... :S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luismontalba luismontalba luismontalba approved these changes

@tbaden tbaden tbaden approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@MiquelRForgeFlow @OCA-git-bot @emagdalenaC2i @pedrobaeza @luismontalba @tbaden @JordiBForgeFlow @oca-travis