[12.0][MIG] account_payment_show_invoice #242

kittiu · 2019-03-29T08:23:02Z

No description provided.

Currently translated at 100.0% (2 of 2 strings) Translation: account-payment-11.0/account-payment-11.0-account_payment_show_invoice Translate-URL: https://translation.odoo-community.org/projects/account-payment-11-0/account-payment-11-0-account_payment_show_invoice/de/

kittiu · 2019-03-29T08:25:00Z

account_payment_show_invoice/views/account_payment_view.xml

+        <field name="inherit_id" ref="account.view_account_payment_tree"/>
+        <field name="arch" type="xml">
+            <field name="partner_id" position="after">
+                <field name="invoice_vendor_references"/>


@lreficent , I change from invoice_ids to invoice_vendor_references. (not sure invoice_ids is your intention?)

kittiu · 2019-03-29T08:28:09Z

account_payment_show_invoice/models/account_payment.py

+class AccountPayment(models.Model):
+    _inherit = 'account.payment'
+
+    @api.multi


@lreficent I change from api.one -> api.multi. In the past, I heard that we should always use api.multi since api.one have performance issue.
But I also see many code using api.one, not sure the performance was fixed. Please suggest.

ntodorova · 2019-04-10T13:09:17Z

account_payment_show_invoice/models/account_payment.py

+    _inherit = 'account.payment'
+
+    @api.multi
+    def _compute_invoice_vendor_references(self):


i think that it is a good practice to include ensure_one() if you change the api from one to multi.

Here, I think the reason to use multi is oppose of using ensure_one() here isn't it? We use multi because we want to compute once for all records.
Please correct me if I am wrong.

When I double think, should that not be @api.depends('invoice_ids')?
Because the field should be changed in case the 'invoice_ids' are changed.

ok, you are right, after we discussed it I agree that @api.multi without ensure_one is fine. : ))

ntodorova · 2019-04-10T13:12:36Z

account_payment_show_invoice/tests/__init__.py

@@ -0,0 +1 @@
+from . import test_payment_ref_invoice


dont't we need a license text here?

I will add it.

ntodorova · 2019-04-10T13:52:16Z

account_payment_show_invoice/views/account_payment_view.xml

+<odoo>
+
+    <record id="view_account_supplier_payment_tree" model="ir.ui.view">
+        <field name="name">account.supplier.payment.tree - show invoice</field>


Is changing the name required?

Can you suggest please? I am not sure what you means (I just migrate from original)

In the original is "account.supplier.payment.tree" and here it is "account.supplier.payment.tree - show invoice", I am just not sure if it should be changed or not : )

Yes. I just check from v11 also. And it also has the - show invoice

True, I am sorry. I have overseen it. That here all is fine.

ntodorova · 2019-04-10T13:55:41Z

account_payment_show_invoice/views/account_payment_view.xml

+    </record>
+
+    <record id="view_account_payment_tree" model="ir.ui.view">
+        <field name="name">account.supplier.payment.tree - show invoice</field>


same as above.

ntodorova · 2019-04-10T13:59:56Z

account_payment_show_invoice/static/description/index.html

@@ -0,0 +1,431 @@
+<?xml version="1.0" encoding="utf-8" ?>


Is this file changed, for me it looks like the one in v11?

This one, I did follow the instruction by using oca-gen-addon-readme

ntodorova · 2019-04-10T14:05:48Z

account_payment_show_invoice/models/account_payment.py

+        for payment in self:
+            ref = payment.invoice_ids.mapped(lambda x: x.reference or x.number)
+            ref.sort()
+            payment.invoice_vendor_references = ', '.join(ref)


I like this function implementation much more than in v11, good job!

Thank you :)

ntodorova · 2019-04-10T14:14:31Z

It looks good, even better in v11. I just have couple of questions before I approve it.

ntodorova

ok, so only the api question is left.

ntodorova · 2019-04-10T15:07:35Z

account_payment_show_invoice/models/account_payment.py

+    _inherit = 'account.payment'
+
+    @api.multi
+    def _compute_invoice_vendor_references(self):


When I double think, should that not be @api.depends('invoice_ids')?
Because the field should be changed in case the 'invoice_ids' are changed.

ntodorova · 2019-04-10T15:21:05Z

account_payment_show_invoice/views/account_payment_view.xml

+<odoo>
+
+    <record id="view_account_supplier_payment_tree" model="ir.ui.view">
+        <field name="name">account.supplier.payment.tree - show invoice</field>


True, I am sorry. I have overseen it. That here all is fine.

kittiu · 2019-04-10T15:57:03Z

ok, so only the api question is left.

Note really, because this is not store=True field. So, it is not necessary (it will be recomputed every time it is called)

ntodorova · 2019-04-10T16:02:22Z

account_payment_show_invoice/README.rst

+To use this module, you need to:
+
+#. Go to 'Invoicing > Vendors > Payments' or to 'Invoicing > Customers >
+   Payments'


I did a function test and did not found the menus mentioned here. Can you please check this too?

ntodorova

LGTM

OCA-git-bot · 2019-04-11T10:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

tbaden

account-payment/account_payment_show_invoice/__manifest__.py

Line 9 in a451bb6

"website": "https://odoo-community.org/",

please change the website in the manifest to: https://github.com/OCA/account-payment

kittiu · 2019-04-20T05:32:21Z

account-payment/account_payment_show_invoice/manifest.py

Line 9 in a451bb6

"website": "https://odoo-community.org/",
please change the website in the manifest to: https://github.com/OCA/account-payment

Done.

tbaden

Code Review

OCA-git-bot · 2019-04-20T09:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

LoisRForgeFlow and others added 8 commits March 29, 2019 14:44

account_payment_show_invoice

8f9f63a

[MIG] account_payment_show_invoice: Migration to 10.0

de6214a

[MIG] account_payment_show_invoice: Migration to 11.0

e4a5e75

[UPD] Update account_payment_show_invoice.pot

af46678

[UPD] README.rst

3a3e989

[UPD] README.rst

04d22ab

Added translation using Weblate (German)

a2a9dcf

kittiu commented Mar 29, 2019

View reviewed changes

kittiu mentioned this pull request Mar 29, 2019

Migration to version 12.0 #201

Closed

16 tasks

pedrobaeza added this to the 12.0 milestone Mar 29, 2019

kittiu force-pushed the 12.0-mig-account_payment_show_invoice branch 2 times, most recently from 77f9707 to 8861a83 Compare April 2, 2019 04:21

ntodorova suggested changes Apr 10, 2019

View reviewed changes

kittiu force-pushed the 12.0-mig-account_payment_show_invoice branch from 8861a83 to a451bb6 Compare April 10, 2019 14:27

ntodorova reviewed Apr 10, 2019

View reviewed changes

ntodorova approved these changes Apr 11, 2019

View reviewed changes

cfreyse approved these changes Apr 11, 2019

View reviewed changes

OCA-git-bot added approved ready to merge labels Apr 11, 2019

tbaden suggested changes Apr 12, 2019

View reviewed changes

OCA-git-bot removed approved ready to merge labels Apr 12, 2019

[12.0][MIG] account_payment_show_invoice

eab500d

kittiu force-pushed the 12.0-mig-account_payment_show_invoice branch from a451bb6 to eab500d Compare April 20, 2019 05:32

tbaden approved these changes Apr 20, 2019

View reviewed changes

OCA-git-bot added approved ready to merge labels Apr 20, 2019

pedrobaeza merged commit 94c2853 into OCA:12.0 Apr 20, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[12.0][MIG] account_payment_show_invoice #242

[12.0][MIG] account_payment_show_invoice #242

kittiu commented Mar 29, 2019

kittiu Mar 29, 2019

kittiu Mar 29, 2019

ntodorova Apr 10, 2019

kittiu Apr 10, 2019

ntodorova Apr 10, 2019

ntodorova Apr 10, 2019

ntodorova Apr 10, 2019

kittiu Apr 10, 2019

ntodorova Apr 10, 2019

kittiu Apr 10, 2019

ntodorova Apr 10, 2019

kittiu Apr 10, 2019

ntodorova Apr 10, 2019

ntodorova Apr 10, 2019

ntodorova Apr 10, 2019

kittiu Apr 10, 2019

ntodorova Apr 10, 2019

kittiu Apr 10, 2019

ntodorova commented Apr 10, 2019

ntodorova left a comment

ntodorova Apr 10, 2019

ntodorova Apr 10, 2019

kittiu commented Apr 10, 2019

ntodorova Apr 10, 2019

kittiu Apr 10, 2019

ntodorova left a comment

OCA-git-bot commented Apr 11, 2019

tbaden left a comment

kittiu commented Apr 20, 2019

tbaden left a comment

OCA-git-bot commented Apr 20, 2019

[12.0][MIG] account_payment_show_invoice #242

[12.0][MIG] account_payment_show_invoice #242

Conversation

kittiu commented Mar 29, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ntodorova commented Apr 10, 2019

ntodorova left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kittiu commented Apr 10, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ntodorova left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Apr 11, 2019

tbaden left a comment

Choose a reason for hiding this comment

kittiu commented Apr 20, 2019

tbaden left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Apr 20, 2019