Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] account_due_list #306

Merged
merged 26 commits into from Feb 4, 2020

Conversation

MiquelRForgeFlow
Copy link
Contributor

Standard migration of account_due_list.

tafaRU and others added 25 commits January 29, 2020 10:59
* amount_residual in payment_view
* maturity_residual, stored with dep. on date_maturity field
* Include also move lines without invoice
* Select by default "From invoice" filter
[IMP] account_due_list: Add fast install script
Problem: Key information, such as the supplier invoice number, does not appear in the due list. The information that appears in the list is inconsistent with the data shown in the list of move lines. The name of the move line is missing.
 Solution: Add the move line name to this list, as it provides valuable info.
remove en.po that was erroneously created by transbot
* Field 'maturity_residual' is dropped, because 'amount_residual' is a stored field in v9
* Rename fields as per names in v9
* Add pre-migration scripts to speed-up the migration to v9
removing
account_due_list/migrations/9.0.1.0.0/pre-migration.py
as not used in 10.0 because the fields stay the same
Currently translated at 100,0% (31 of 31 strings)

Translation: account-payment-11.0/account-payment-11.0-account_due_list
Translate-URL: https://translation.odoo-community.org/projects/account-payment-11-0/account-payment-11-0-account_due_list/de/
Currently translated at 93.5% (29 of 31 strings)

Translation: account-payment-12.0/account-payment-12.0-account_due_list
Translate-URL: https://translation.odoo-community.org/projects/account-payment-12-0/account-payment-12-0-account_due_list/it/
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Currently translated at 96.4% (27 of 28 strings)

Translation: account-payment-12.0/account-payment-12.0-account_due_list
Translate-URL: https://translation.odoo-community.org/projects/account-payment-12-0/account-payment-12-0-account_due_list/pt/
Currently translated at 100.0% (28 of 28 strings)

Translation: account-payment-12.0/account-payment-12.0-account_due_list
Translate-URL: https://translation.odoo-community.org/projects/account-payment-12-0/account-payment-12-0-account_due_list/pt_BR/
@OCA-git-bot
Copy link
Contributor

Hi @smangukiya,
some modules you are maintaining are being modified, check this out!

@MiquelRForgeFlow MiquelRForgeFlow mentioned this pull request Jan 29, 2020
15 tasks
@AdriaGForgeFlow
Copy link
Contributor

AdriaGForgeFlow commented Jan 29, 2020

Commit message should begin with [MIG] not [IMP] right?

Copy link

@JoanSForgeFlow JoanSForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on local, LGTM 👍

Copy link
Contributor

@AdriaGForgeFlow AdriaGForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review 👍

Code review, small comment below. Could you use this PR to update company name? (eficent --> forgeflow)

account_due_list/views/payment_view.xml Outdated Show resolved Hide resolved
@MiquelRForgeFlow
Copy link
Contributor Author

Commit message should begin with [MIG] not [IMP] right?

haha good

@MiquelRForgeFlow
Copy link
Contributor Author

comments attended

@dreispt
Copy link
Sponsor Member

dreispt commented Feb 4, 2020

/ocabot merge

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-306-by-dreispt-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 4, 2020
Signed-off-by dreispt
@OCA-git-bot OCA-git-bot merged commit ed81fcc into OCA:13.0 Feb 4, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 775ef0b. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 13.0-mig-account_due_list branch February 5, 2020 09:08
@alexandreduf
Copy link
Contributor

Hi,

I'm not sure this is the right place to put this comment, but I'll try it.

The Readme's "Usage" section says :

To use this module, you need to go to:
Invoicing > Accounting > Payments and due list

Problem
When you run the runbot, there is no accounting menu. So it's impossible for a novice user (like me) to try this module.
Runbot_no_accounting

Thanks for the great work!

@pedrobaeza
Copy link
Member

Enable in your user "Show Full Accounting Features".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet