Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileParser default value for extra_fields #61

Closed
ecino opened this issue Nov 5, 2014 · 2 comments
Closed

FileParser default value for extra_fields #61

ecino opened this issue Nov 5, 2014 · 2 comments
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.

Comments

@ecino
Copy link

ecino commented Nov 5, 2014

#23 Introduced a problem in file_parser.py:

https://github.com/OCA/bank-statement-reconcile/blob/7.0/account_statement_base_import/parser/file_parser.py#L43

The parameter extra_fields is in fact mandatory as it is now, since it defines the conversion_dict and the keys_to_validate fields. Thus, it should not be named extra_fields anymore, but fields and should not take a None default value. If no value is passed, line 62 will raise an AttributeError (NoneType has no keys)

@pedrobaeza
Copy link
Member

Can you please make a PR with the changes you mentioned?

Thanks.

@github-actions
Copy link

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 31, 2021
@github-actions github-actions bot closed this as completed Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

No branches or pull requests

2 participants