7.0 Conversion_dict is now created in the generic parser #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| super(GenericFileParser, self).__init__(parse_name, ftype=ftype, **kwargs) | ||
| conversion_dict = { | ||
| 'ref': unicode, | ||
| 'label': unicode, |
There was a problem hiding this comment.
Better to use ustr from openerp.tools
There was a problem hiding this comment.
Seems better now?
There was a problem hiding this comment.
better to import
from openerp.tools import ustr
It may be the same function, but openerp.tools seems safer and makes more sense
There was a problem hiding this comment.
Ok, thank you for the information
A new rule for automatic reconciliation and a cron [rebased]
|
LGTM 👍 |
| 'date': datetime.datetime, | ||
| 'amount': float_or_zero, | ||
| } | ||
| super(GenericFileParser, self).__init__(parse_name, ftype=ftype, extra_fields=conversion_dict, **kwargs) |
|
Needs to be rebased in order to merge |
|
rebased! |
|
Unrelated Travis error, so 👍 |
pedrobaeza
added a commit
that referenced
this pull request
Sep 26, 2014
[IMP] account_statement_base_import: 7.0 Conversion_dict is now created in the generic parser
tschanzt
pushed a commit
to tschanzt/account-reconcile
that referenced
this pull request
May 10, 2019
Fix tax account on chart 1170 -> 2200
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conversion dict is displaced from the file_parser to the generic_parser in order to avoid the error of the validate function when creating a new parser which does not contain the 4 basc fields (ref, amount, date, label)
The old launchpad link :
https://code.launchpad.net/~akretion-team/banking-addons/account_statement_base_import_conversion_dict/+merge/198235