[ADD] add module 'account_easy_reconcile' : v8 migration #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def _get_date(reconcile): | ||
| if reconcile.last_history.date: | ||
| return datetime.strptime(reconcile.last_history.date, | ||
| DEFAULT_SERVER_DATETIME_FORMAT) |
There was a problem hiding this comment.
use fields.Datetime.from_string(reconcile.last_history.date)
|
|
||
| @api.one | ||
| @api.depends('reconcile_ids', 'reconcile_partial_ids') | ||
| def _reconcile_line_ids(self): |
There was a problem hiding this comment.
Could be renamed _compute_reconcile_line_ids or _get_reconcile_line_ids for clarity
|
Still some cleaning to do |
[IMP] add translations [FIX] add decorator multi
damdam-s
force-pushed
the
migrate_account_easy_reconcile
branch
from
ccc4e52
to
f559a5f
Compare
| dummy, where, params = ml_obj._where_calc( | ||
| cr, uid, eval(rec.filter), context=context).get_sql() | ||
| eval(self.filter)).get_sql() |
There was a problem hiding this comment.
please change this to use safe_eval.
A PR on 7.0 to fix this is welcome too.
|
@gurneyalex fixed. |
|
👍 |
|
@damdam-s Thanks for the fixes, can you address the last 2-3 comments I have made? If you disagree just say it so 😄 |
|
@yvaucher done. oups ;) I forgot some of your comments. |
|
Thanks for the fixes 👍 merging... |
grindtildeath
pushed a commit
to grindtildeath/account-reconcile
that referenced
this pull request
Oct 16, 2019
8.0 improve selection of invoices to pay, solves OCA#93
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.