-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[9.0] [port] base_transaction_id #127
Conversation
a73a2c8
to
81f2977
Compare
lint is complaining about |
81f2977
to
2a69b21
Compare
@yvaucher, this is only a warning. Real problems are:
|
2a69b21
to
9d24a1f
Compare
@pedrobaeza Thx, I fixed it. |
|
||
* Yannick Vaucher <yannick.vaucher@camptocamp.com> | ||
* Joël Grand-Guillaume <joel.grandguillaume@camptocamp.com> | ||
* Alexandre Fayolles <alexandre.fayolles@camptocamp.com> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/Fayolles/Fayolle/
1ea7cfb
to
57733a3
Compare
Thx @guewen Fixed those typo |
Currently, the js inheritance needs a fixup (it does a silent error and makes the view unloadable (blank screen with Odoo logo and top menu bar without menus)) |
And we are good |
travis is not starting ? |
@@ -8,9 +8,12 @@ cache: pip | |||
|
|||
addons: | |||
apt: | |||
sources: | |||
- pov-wkhtmltopdf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpicking: sources
is not aligned with packages
No idea why travis does not start... |
f4d50fc
to
dc9a76d
Compare
@guewen nitpicking fixed, and travis is starting this was perhaps blocking it? |
👍 |
91f113b
to
17c2124
Compare
- Reactivate module - move files in views and models dirs - create README.rst from description - make list of contributors - remove change for invoice created on picking as it doesn't exist anymore in Odoo Community - move overrides in bank statement as logic moved in move lines - adapt view inheritance to not depends on string attribute
f46b29e
to
ad1991b
Compare
I did some fixes and ensured last commits in 8.0 were there. This PR is ready |
ad1991b
to
3d5e954
Compare
# | ||
# You should have received a copy of the GNU Affero General Public License | ||
# along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
short header here
Nice work. Just cosmetic modifications in my comments. |
############################################################################## | ||
from openerp.osv import orm, fields | ||
from openerp import models, fields, api | ||
from openerp.osv import expression |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from openerp.models import expression ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer direct import than using an alias
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems legit
Fixed license headers |
👍 |
Portuguese translations [8.0]
No description provided.