[ADD] 11.0 mig account mass reconcile #197

mpanarin · 2018-01-04T18:50:11Z

No description provided.

simahawk · 2018-01-08T08:18:41Z

account_mass_reconcile/README.rst

+Bug Tracker
+===========
+
+Bugs are tracked on `GitHub Issues <https://github.com/OCA/bank-statement-reconcile/issues>`_.


https://github.com/OCA/account-reconcile/issues

simahawk · 2018-01-08T08:18:55Z

account_mass_reconcile/README.rst

+* Vincent Renaville <vincent.renaville@camptocamp.com>
+* Alexandre Fayolle <alexandre.fayolle@camptocamp.com>
+* Joël Grand-Guillaume <joel.grandguillaume@camptocamp.com>
+* Nicolas Bessis <nicolas.bessi@camptocamp.com>


simahawk · 2018-01-08T08:19:27Z

account_mass_reconcile/__manifest__.py

@@ -0,0 +1,22 @@
+# © 2012-2016 Camptocamp SA (Guewen Baconnier, Damien Crier, Matthieu Dietrich)


(c) -> Copyright

simahawk · 2018-01-08T08:23:04Z

account_mass_reconcile/models/base_advanced_reconciliation.py

+        for value, ovalue in product(values, opposite_values):
+            # we do not need to compare all values, if one matches
+            # we are done
+            if MassReconcileAdvanced._compare_values(key, value, ovalue):


shouldn't we use self._* instead of calling the class straight?

simahawk · 2018-01-08T08:26:00Z

account_mass_reconcile/models/base_reconciliation.py

+            'move_id')
+        return ["account_move_line.{}".format(col) for col in aml_cols]
+
+    def _select(self, *args, **kwargs):


wouldn't be better to prefix these methods' names w/ something to avoid possible clashes w/ odoo internals?

simahawk · 2018-01-08T08:27:27Z

account_mass_reconcile/models/base_reconciliation.py

+            line_rs.reconcile(
+                writeoff_acc_id=writeoff_account,
+                writeoff_journal_id=self.journal_id
+                )


indent back

simahawk · 2018-01-08T08:28:29Z

account_mass_reconcile/models/mass_reconcile.py

+        string='Date of reconciliation',
+        default='newest',
+    )
+    filter = fields.Char(


can we prefix this field name to avoid clash w/ built-in?

simahawk · 2018-01-08T08:29:08Z

account_mass_reconcile/models/mass_reconcile.py

+        ]
+
+    def _get_rec_method(self):
+        return self._get_all_rec_method()


this indirection is not needed

Not sure what you mean here

you can merge "_get_all_rec_method" into this method and rename it _selection_name (I don't see those methods used somewhere else)

hmm, thinking about it twice: _get_all_rec_method it's kind of an api method, so:

rename _get_rec_method to _selection_name

rename _get_all_rec_method to _get_reconcilation_methods

simahawk · 2018-01-08T08:33:02Z

account_mass_reconcile/tests/test_reconcile.py

+            self.env['account.mass.reconcile.method']
+        )
+        self.mass_rec = self.mass_rec_obj.create(
+            {


poor indentation here

simahawk · 2018-01-08T08:34:00Z

account_mass_reconcile/tests/test_reconcile.py

+
+class TestReconcile(common.TransactionCase):
+
+    def setUp(self):


we can use SavepointCase + setUpClass to avoid creating records again and again on each test.

ghost · 2018-01-17T16:03:10Z

account_mass_reconcile/i18n/account_easy_reconcile.pot

@@ -0,0 +1,602 @@
+# Translation of Odoo Server.


Remove the file

yvaucher

LGTM in term of code, however for the history, I see some issues.

Here we are loosing all history prior to 2952cbe , we probably want to include the history of account_easy_reconcile and account_advanced_reconcile

https://github.com/OCA/account-reconcile/commits/10.0/account_easy_reconcile
https://github.com/OCA/account-reconcile/commits/10.0/account_advanced_reconcile

those translations commits can be squashed

grindtildeath

Some non-blocking things, otherwise looks good but please consider @yvaucher 's last comment.

grindtildeath · 2018-02-23T09:16:51Z

account_mass_reconcile/__manifest__.py

    'license': 'AGPL-3',
-    "auto_install": False,
-    'installable': True,


Don't we want to keep this key ?

no they are defaults, not needed

grindtildeath · 2018-02-23T09:26:57Z

account_mass_reconcile/models/mass_reconcile_history.py

    )
    reconcile_line_ids = fields.Many2many(
        comodel_name='account.move.line',
        relation='account_move_line_history_rel',
        string='Reconciled Items',
-        compute='_get_reconcile_line_ids'
+        compute='_get_reconcile_line_ids',


Compute method should start with _compute

@mpanarin ping?

simahawk · 2018-04-24T06:18:55Z

@mpanarin check @yvaucher comment on history pls

mpanarin · 2018-04-24T11:37:43Z

@simahawk @yvaucher
history added + few fix commit that came after my pr

For reconciling entries automatically (lp:account-extra-addons rev 22)

based on account_easy_reconcile (lp:c2c-financial-addons/6.1 rev 24.1.20)

using account_easy_reconcile (lp:c2c-financial-addons/6.1 rev 24.2.1)

… of code which have still to be exectuted, not sure if it will runs or just miserably crash (lp:c2c-financial-addons/6.1 rev 24.2.2)

(lp:c2c-financial-addons/6.1 rev 24.2.6)

(lp:c2c-financial-addons/6.1 rev 24.2.7)

(lp:c2c-financial-addons/6.1 rev 58)

…ents that we made. This is mostly based on : account_statement_ext -> provide profile per bank statement, remove period, choose to use balance check or not,... account_statement_base_completion -> provide a completion rule system to fullfill the bank statement (partner, account,...) account_statement_base_import -> provide a base to create your own file parser for each bank/office and link it to a profile account_statement_transactionid_completion and account_statement_transactionid_import to use the transaction ID recorded in th SO account_advanced_reconcile -> An advanced way to setup reconciliation rules on every account account_financial_report_webkit -> some little fixes (lp:c2c-financial-addons/6.1 rev 63)

to order the reconcile methods

…rtially reconciled items from a profile to easy the verification and controlling

[IMP] add translations [FIX] add decorator multi

…ed by transbot

…ile method

…l" button

pedrobaeza added this to the 11.0 milestone Jan 4, 2018

mpanarin force-pushed the 11.0-mig-account_mass_reconcile branch 3 times, most recently from f400410 to 7a79068 Compare January 5, 2018 11:31

simahawk requested changes Jan 8, 2018

View reviewed changes

mpanarin force-pushed the 11.0-mig-account_mass_reconcile branch 2 times, most recently from 70cf63d to fcbf3e3 Compare January 10, 2018 09:31

ghost suggested changes Jan 17, 2018

View reviewed changes

account_mass_reconcile/i18n/account_easy_reconcile.pot Outdated

@@ -0,0 +1,602 @@

# Translation of Odoo Server.

Copy link

ghost Jan 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the file

ghost approved these changes Jan 26, 2018

View reviewed changes

simahawk approved these changes Feb 2, 2018

View reviewed changes

mpanarin changed the title ~~[WIP] 11.0 mig account mass reconcile~~ [ADD] 11.0 mig account mass reconcile Feb 2, 2018

mpanarin force-pushed the 11.0-mig-account_mass_reconcile branch from 84c7018 to f5e3266 Compare February 2, 2018 10:14

yvaucher requested changes Feb 2, 2018

View reviewed changes

grindtildeath reviewed Feb 23, 2018

View reviewed changes

mpanarin force-pushed the 11.0-mig-account_mass_reconcile branch from f5e3266 to a3edc47 Compare April 24, 2018 11:36

mpanarin force-pushed the 11.0-mig-account_mass_reconcile branch 4 times, most recently from d7dc959 to 8aab378 Compare April 24, 2018 12:59

sebastienbeau and others added 9 commits April 25, 2018 11:46

[INIT] add a new module account_easy_reconcile.

6f32255

For reconciling entries automatically (lp:account-extra-addons rev 22)

[MRG] account_statement_reconcile,renamed account_advanced_reconcile

c769d39

based on account_easy_reconcile (lp:c2c-financial-addons/6.1 rev 24.1.20)

[REF] refactoring of account_advanced_reconcile

78f7fdf

using account_easy_reconcile (lp:c2c-financial-addons/6.1 rev 24.2.1)

[ADD] account_advanced_reconcile: intermediate commit for a big piece…

446540b

… of code which have still to be exectuted, not sure if it will runs or just miserably crash (lp:c2c-financial-addons/6.1 rev 24.2.2)

[REF] account_advanced_reconcile: moved file

f349710

(lp:c2c-financial-addons/6.1 rev 24.2.6)

[REF] account_advanced_reconcile: arrange files

941c752

(lp:c2c-financial-addons/6.1 rev 24.2.7)

[MRG] account_advanced_reconcile: From customer branch

40f8cca

(lp:c2c-financial-addons/6.1 rev 58)

[ADD] account_advanced_reconcile: fr po

ec03680

guewen and others added 26 commits April 25, 2018 12:38

[FIX] account_reconcile: reword entries to items

e68ee7d

[IMP] account_reconcile: updated french translation

130b446

[FIX] account_easy_reconcile: security CSV file is not loaded

f45bfbe

[ADD] account_easy_reconcile: easy-reconcile multi-company support

e24fc86

[FIX] account_advanced_reconcile: prevent crash if move ref is null

3fe9aab

[IMP] account_easy_reconcile: use the 'handle' widget

d97cb16

to order the reconcile methods

[IMP] account_reconcile: Translation template files.

f88df51

[IMP] account_easy_reconcile: Add buttons to open unreconciled and pa…

81058db

…rtially reconciled items from a profile to easy the verification and controlling

Launchpad automatic translations update.

289c370

Set as uninstallable and moved to __unported__ all modules.

d2467d8

[ADD] add module 'account_easy_reconcile' : v8 migration

1bc8b6e

[FIX] account_easy_reconcile: code review

b9ab2f7

[IMP] account_easy_reconcile: add tests

a780bf1

[IMP] add translations [FIX] add decorator multi

[IMP] account_easy_reconcile: add YAML tests

42faf3a

OCA Transbot updated translations from Transifex

ac0c14b

[MOV] move addons out of __unported__ (they remain not installable)

69bcb2a

[MIG] account_easy_reconcile: Make modules uninstallable

d51e54d

Merge and migrate account_easy_reconcile and account_advanced_reconcile

8a64e30

OCA Transbot updated translations from Transifex

4c5b15c

[FIX] account_mass_reconcile: remove en.po that was erroneously creat…

053cf9d

…ed by transbot

[FIX] account_mass_reconcile: Fix writeoff variables passed to reconc…

1de1d53

…ile method

[MIG] account_mass_reconcile: Make modules uninstallable

f5e6fbb

[MIG] account_mass_reconcile: Rename manifest files

b73760c

[FIX] account_mass_reconcile: Remove now non-existing "Display partia…

fc3a947

…l" button

[MIG] account_mass_reconcile: Init mgration to 10.0

ae830cc

[MIG] account_mass_reconcile: Migration to odoo 11

429716f

mpanarin force-pushed the 11.0-mig-account_mass_reconcile branch from 8aab378 to 429716f Compare April 25, 2018 09:38

yvaucher approved these changes Jun 28, 2018

View reviewed changes

yvaucher merged commit a89652a into OCA:11.0 Jun 28, 2018

emagdalenaC2i mentioned this pull request Dec 28, 2018

Migration to version 11.0 #186

Closed

26 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD] 11.0 mig account mass reconcile #197

[ADD] 11.0 mig account mass reconcile #197

mpanarin commented Jan 4, 2018

simahawk Jan 8, 2018

simahawk Jan 8, 2018

simahawk Jan 8, 2018

simahawk Jan 8, 2018

simahawk Jan 8, 2018

simahawk Jan 8, 2018

simahawk Jan 8, 2018

simahawk Jan 8, 2018

mpanarin Jan 9, 2018

simahawk Feb 2, 2018

simahawk Feb 2, 2018

simahawk Jan 8, 2018

simahawk Jan 8, 2018

ghost Jan 17, 2018

yvaucher left a comment

grindtildeath left a comment

grindtildeath Feb 23, 2018

simahawk Apr 24, 2018

grindtildeath Feb 23, 2018

simahawk Apr 24, 2018

simahawk commented Apr 24, 2018

mpanarin commented Apr 24, 2018

		@@ -0,0 +1,22 @@
		# © 2012-2016 Camptocamp SA (Guewen Baconnier, Damien Crier, Matthieu Dietrich)


		class TestReconcile(common.TransactionCase):

		def setUp(self):

[ADD] 11.0 mig account mass reconcile #197

[ADD] 11.0 mig account mass reconcile #197

Conversation

mpanarin commented Jan 4, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yvaucher left a comment

Choose a reason for hiding this comment

grindtildeath left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

simahawk commented Apr 24, 2018

mpanarin commented Apr 24, 2018