Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10.0 mig account mass reconcile transaction ref #207

Conversation

damdam-s
Copy link
Member

@damdam-s damdam-s commented Apr 6, 2018

No description provided.

@damdam-s damdam-s mentioned this pull request Apr 6, 2018
23 tasks
@damdam-s damdam-s force-pushed the 10.0-mig-account_mass_reconcile_transaction_ref branch from acaa3e1 to 7b234c6 Compare April 6, 2018 13:18
@pedrobaeza
Copy link
Member

Please check Travis. Maybe a missing dependency in oca_repositories.txt?

@pedrobaeza pedrobaeza added this to the 10.0 milestone Apr 6, 2018
@damdam-s
Copy link
Member Author

damdam-s commented Apr 6, 2018

still the same error linked to account_mass_reconcile test 😢

@pedrobaeza
Copy link
Member

Agh, I remember... Let's chat in #204

@fclementic2c
Copy link
Member

functional test Ok
👍

Copy link
Contributor

@grindtildeath grindtildeath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@grindtildeath grindtildeath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it works 👍

<field name="inherit_id" ref="account.view_account_move_filter"/>
<field name="arch" type="xml">
<separator position="after">
<filter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should add that for migration ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch ! @damdam-s can you drop the related commit ?

Copy link

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eyeball review: LG

@grindtildeath
Copy link
Contributor

Since @damdam-s is too busy, I opened #222 and this can be closed.

@grindtildeath grindtildeath mentioned this pull request Oct 8, 2018
26 tasks
@pedrobaeza pedrobaeza closed this Oct 11, 2018
bjeficent pushed a commit to ForgeFlow/account-reconcile that referenced this pull request Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants