-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0][MIG] account_reconcile_rule (account_operation_rule v9) #209
[11.0][MIG] account_reconcile_rule (account_operation_rule v9) #209
Conversation
4419041
to
5cfe225
Compare
8b1d1af
to
47b862c
Compare
@@ -0,0 +1,23 @@ | |||
# Author: Guewen Baconnier | |||
# © 2014-2016 Camptocamp SA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright
'depends': [ | ||
'account', | ||
], | ||
'website': 'http://www.camptocamp.com', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'view/account_reconcile_rule_view.xml', | ||
'security/ir.model.access.csv', | ||
], | ||
'installable': True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can drop these flags
@@ -0,0 +1,152 @@ | |||
# Translation of Odoo Server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove POT
@@ -0,0 +1,4 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
empty line not needed
@api.model | ||
@api.returns('account.reconcile.model') | ||
def models_for_reconciliation(self, statement_line_id, move_line_ids): | ||
""" Find the rule for the current reconciliation and returns the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"""Find reconcile models for given statement and move lines.
explain "how" in the extra lines.
|
||
var core = require('web.core'); | ||
var reconciliation_renderer = require('account.ReconciliationRenderer'); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/*
Explain what you do here
*/`
return deferred; | ||
}, | ||
/** | ||
* Click on add_line link if preset button have been clicked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
???
'code': 'CASH', | ||
'type': 'cash', | ||
}) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove some useless empty line
|
||
@classmethod | ||
def setUpClass(cls): | ||
super(AccountReconciliationModelTestCase, cls).setUpClass() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can call super()
w/out args
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM (only some commented lines to remove), tested on runbot, works great. Thanks!
// var deferred = this._super(); | ||
// deferred.done(this.operation_rules()); | ||
// return deferred; | ||
// } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the commented lines can be removed
47b862c
to
009122c
Compare
009122c
to
f9a850f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the Headers have the wrong Daterange in it for the licence. But otherwise 👍
@tschanzt Can you approve or add suggestions to correct the date range so we can get this merged ? 🙏 😉 |
@tschanzt ping |
This PR has the |
@fclementic2c how about an merge here? Everythings seems allright from over here. Thx! |
@fclementic2c sorry for poking you on this one, I have learned from @OSevangelist that you are more into funtional stuff. @tafaRU or @jbeficent could you please be so kind and merge this one? Thanks! |
/ocabot merge |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at e70bb0f. Thanks a lot for contributing to OCA. ❤️ PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into |
Todo :