Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][MIG] account_mass_reconcile #235

Merged
merged 19 commits into from
May 17, 2019
Merged

[12.0][MIG] account_mass_reconcile #235

merged 19 commits into from
May 17, 2019

Conversation

AdriaGForgeFlow
Copy link
Contributor

@AdriaGForgeFlow AdriaGForgeFlow commented Dec 4, 2018 •
edited
Loading

Migration of module account_mass_reconcile to v12

mdietrichc2c and others added 18 commits December 4, 2018 08:32
@mdietrichc2c @AdriaGForgeFlow
Merge and migrate account_easy_reconcile and account_advanced_reconcile
f846d92
@oca-transbot @AdriaGForgeFlow
OCA Transbot updated translations from Transifex
468a5c5
@sbidoul @AdriaGForgeFlow
[FIX] account_mass_reconcile: remove en.po that was erroneously creat…
84ac56b 
…ed by transbot
@florian-dacosta @AdriaGForgeFlow
[FIX] account_mass_reconcile: Fix writeoff variables passed to reconc…
b69766e 
…ile method
@pedrobaeza @AdriaGForgeFlow
[MIG] account_mass_reconcile: Make modules uninstallable
fdcc808
@pedrobaeza @AdriaGForgeFlow
[MIG] account_mass_reconcile: Rename manifest files
b2b96b5
@mdietrichc2c @AdriaGForgeFlow
[FIX] account_mass_reconcile: Remove now non-existing "Display partia…
4a48768 
…l" button
@grindtildeath @AdriaGForgeFlow
[MIG] account_mass_reconcile: Init mgration to 10.0
934c823
@AdriaGForgeFlow
[MIG] account_mass_reconcile: Migration to odoo 11
9d01cc9
@oca-travis @AdriaGForgeFlow
[UPD] Update account_mass_reconcile.pot
7af54b7
@MiquelRForgeFlow @AdriaGForgeFlow
[FIX] Readme display
54bb831
@MiquelRForgeFlow @AdriaGForgeFlow
[FIX] Super call on static methods
4e9ee20
@MiquelRForgeFlow @AdriaGForgeFlow
[FIX] Deprecated icon on some buttons
4c79d11
@JordiBForgeFlow @AdriaGForgeFlow
account_mass_reconcile: fix in python3 code conversion
046107c
@oca-travis @AdriaGForgeFlow
[UPD] Update account_mass_reconcile.pot
898abc1
@osoul @AdriaGForgeFlow
Translated using Weblate (Arabic)
55a21ff 
Currently translated at 78.2% (68 of 87 strings)

Translation: account-reconcile-11.0/account-reconcile-11.0-account_mass_reconcile
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-11-0/account-reconcile-11-0-account_mass_reconcile/ar/
@oca-travis @AdriaGForgeFlow
[UPD] Update account_mass_reconcile.pot
a69faf8
@MiquelRForgeFlow @AdriaGForgeFlow
[ADD] account_mass_reconcile: assure migration is ok
fbaad0a
@AdriaGForgeFlow AdriaGForgeFlow changed the title [12.0][ mig account mass reconcile [12.0][MIG] account_mass_reconcile Dec 4, 2018
@pedrobaeza pedrobaeza added this to the 12.0 milestone Dec 4, 2018
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 4, 2018
Closed
8 tasks
grindtildeath
grindtildeath reviewed Mar 7, 2019
View reviewed changes
Copy link
Contributor

@grindtildeath grindtildeath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks ! 👍

Can you just fix this icon ? dc0973a#diff-8ff84e574ea4ebeff6b0c36608d3930aR84

image

@AdriaGForgeFlow AdriaGForgeFlow force-pushed the 12.0-mig-account_mass_reconcile branch from dc0973a to fcab4d0 Compare March 8, 2019 07:33
@AdriaGForgeFlow
Copy link
Contributor Author

Looks good, thanks !

Can you just fix this icon ? dc0973a#diff-8ff84e574ea4ebeff6b0c36608d3930aR84

image

Done 👍

@tbaden
Copy link
Member

tbaden commented Apr 11, 2019 •
edited
Loading

@ageficent cant find the menu metioned in readme unless I install the module account_accountant which is no longer a community module. Maybe another module can fix this as well, but in the runbot instance there is no such menu.

Bildschirmfoto 2019-04-11 um 11 23 14

Bildschirmfoto 2019-04-11 um 11 23 06

@AdriaGForgeFlow
Copy link
Contributor Author

AdriaGForgeFlow commented Apr 11, 2019 •
edited
Loading

@ageficent cant find the menu metioned in readme unless I install the module account_accountant which is no longer a community module. Maybe another module can fix this as well, but in the runbot instance there is no such menu.

Indeed the menu is not there. I have updated now the readme.
In order to access the Automatic Mass Reconcile you need first to give to the user the permissions to see the full accounting features and then go to Invoicing / Accounting.

image

Thanks 👍

tbaden
tbaden approved these changes Apr 11, 2019
View reviewed changes
Copy link
Member

@tbaden tbaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

account-reconcile/account_mass_reconcile/models/__init__.py

Lines 1 to 7 in c30b739

from . import mass_reconcile
from . import base_reconciliation
from . import base_advanced_reconciliation
from . import simple_reconciliation
from . import advanced_reconciliation
from . import mass_reconcile_history
from . import res_config

cosmetical change:
sort alphabetically

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@grindtildeath
Copy link
Contributor

@ageficent
If you still have some time on this mig, I'm wondering if we could include #253 in this base module instead of having two separated module ?

@gurneyalex gurneyalex merged commit 246f005 into OCA:12.0 May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grindtildeath grindtildeath grindtildeath approved these changes

@tbaden tbaden tbaden approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet