-
-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.0][MIG] account_move_reconcile_helper #246
Conversation
I don't know why runbot fail, account_balance_line is migrated to 12.0. Can anyone help me? |
You have to add |
Oh! Sorry, I miss that! Now it's done and 🍏! cc @benwillig @Jortolsa @fuentes010 @ioans73 @Saphery @Willerr-mo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your work 👍
just a minor change (see below)
and please squash your commits.
|
||
<odoo> | ||
|
||
<record model="ir.ui.view" id="account_move_line_tree_view"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aesthetic change:
id before model
use original id
In the case where an inherited view has a name which does not follow the guidelines set above, prefer naming the inherited view after the original over using a name which follows the guidelines. This eases looking up the original view and other inheritance if they all have the same name.
not approve relevant
'data': [ | ||
'views/account_move_line.xml', | ||
], | ||
'demo': [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you dont use this tag, just delete it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the migration
154cd9f
to
2eb2096
Compare
@tbaden Squash and minor changes done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@pedrobaeza Can you review this? |
Merging blindly as it seems there are enough reviewers. /ocabot merge |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 024232f. Thanks a lot for contributing to OCA. ❤️ PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into |
Standard migration