Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][MIG] account_move_reconcile_helper #246

Closed

Conversation

Abranes
Copy link
Member

@Abranes Abranes commented Mar 28, 2019

Standard migration

@Abranes
Copy link
Member Author

Abranes commented Mar 28, 2019

I don't know why runbot fail, account_balance_line is migrated to 12.0.

Can anyone help me?

@pedrobaeza
Copy link
Member

You have to add oca_dependencies.txt file in root for adding extra OCA repositories for dependencies.

@Abranes
Copy link
Member Author

Abranes commented Mar 29, 2019

Oh! Sorry, I miss that! Now it's done and 🍏!

cc @benwillig @Jortolsa @fuentes010 @ioans73 @Saphery @Willerr-mo

Copy link
Member

@tbaden tbaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your work 👍
just a minor change (see below)
and please squash your commits.


<odoo>

<record model="ir.ui.view" id="account_move_line_tree_view">
Copy link
Member

@tbaden tbaden Apr 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aesthetic change:
id before model

use original id

In the case where an inherited view has a name which does not follow the guidelines set above, prefer naming the inherited view after the original over using a name which follows the guidelines. This eases looking up the original view and other inheritance if they all have the same name.

not approve relevant

'data': [
'views/account_move_line.xml',
],
'demo': [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you dont use this tag, just delete it

Copy link

@benwillig benwillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the migration

@Abranes Abranes force-pushed the 12.0-mig-account_move_reconcile_helper branch from 154cd9f to 2eb2096 Compare June 13, 2019 14:33
@Abranes
Copy link
Member Author

Abranes commented Jun 13, 2019

@tbaden Squash and minor changes done!

Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Abranes
Copy link
Member Author

Abranes commented Aug 8, 2019

@pedrobaeza Can you review this?

@pedrobaeza pedrobaeza added this to the 12.0 milestone Aug 8, 2019
@pedrobaeza
Copy link
Member

Merging blindly as it seems there are enough reviewers.

/ocabot merge

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Rebased to 12.0-ocabot-merge-pr-246-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Aug 8, 2019
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 024232f. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 12.0.

@OCA-git-bot OCA-git-bot closed this Aug 8, 2019
@Abranes Abranes deleted the 12.0-mig-account_move_reconcile_helper branch August 8, 2019 10:46
@OCA-git-bot OCA-git-bot mentioned this pull request Aug 8, 2019
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants