Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0][ADD] auto_reconcile_structured_ref #267

Merged

Conversation

tschanzt
Copy link

@tschanzt tschanzt commented Jul 8, 2019

Replaces odoo automatic reconcile button with button, that only reconciles based on the ref.
@vrenaville can you have a look at this one? its based on the l10n-switzerland one.

Copy link
Contributor

@jcoux jcoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just technical review.

if aml.account_id.internal_type == 'liquidity':
payment_aml_rec = (payment_aml_rec | aml)
else:
amount = self.amount
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You indicate line 56 that the customizations are done, and back to odoo code.
But for amount, I see that on Odoo:
amount = aml.currency_id and aml.amount_residual_currency or aml.amount_residual
https://github.com/odoo/odoo/blob/10.0/addons/account/models/account_bank_statement.py#L720

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. im not sure why this change is there ill update it

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.

auto_reconcile_structured_ref/views/assets.xml Outdated Show resolved Hide resolved
Timon Tschanz and others added 2 commits July 10, 2019 13:40
Co-Authored-By: jcoux <julien.coux@camptocamp.com>
Copy link
Member

@i-vyshnevska i-vyshnevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems it can be more generic like "auto_reconcile_specific"

@@ -0,0 +1,3 @@
To use this module following steps are required:
1. Go to the Bank Statement reconciliation view
2. Press the "Automatic ESR reconciliation" button
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESR to replace

auto_reconcile_structured_ref/readme/DESCRIPTION.rst Outdated Show resolved Hide resolved
@tschanzt
Copy link
Author

@i-vyshnevska i updated it. although i disagree that we should call it "auto_reconcile_specific" it is supposed to only reconcile based on the structured reference so we should also say so as well.

Copy link
Contributor

@jcoux jcoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically good for me 👍
Thanks for changes.

@guewen
Copy link
Member

guewen commented Jan 31, 2020

/ocabot merge

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 10.0-ocabot-merge-pr-267-by-guewen-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 31, 2020
Signed-off-by guewen
@OCA-git-bot OCA-git-bot merged commit 492430b into OCA:10.0 Jan 31, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2cf6a6e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants