New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.0][ADD] auto_reconcile_structured_ref #267
[10.0][ADD] auto_reconcile_structured_ref #267
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just technical review.
if aml.account_id.internal_type == 'liquidity': | ||
payment_aml_rec = (payment_aml_rec | aml) | ||
else: | ||
amount = self.amount |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You indicate line 56 that the customizations are done, and back to odoo code.
But for amount, I see that on Odoo:
amount = aml.currency_id and aml.amount_residual_currency or aml.amount_residual
https://github.com/odoo/odoo/blob/10.0/addons/account/models/account_bank_statement.py#L720
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch. im not sure why this change is there ill update it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated.
Co-Authored-By: jcoux <julien.coux@camptocamp.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems it can be more generic like "auto_reconcile_specific"
auto_reconcile_structured_ref/models/account_bank_statement_line.py
Outdated
Show resolved
Hide resolved
auto_reconcile_structured_ref/models/account_bank_statement_line.py
Outdated
Show resolved
Hide resolved
auto_reconcile_structured_ref/static/src/xml/account_reconciliation.xml
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,3 @@ | |||
To use this module following steps are required: | |||
1. Go to the Bank Statement reconciliation view | |||
2. Press the "Automatic ESR reconciliation" button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESR to replace
@i-vyshnevska i updated it. although i disagree that we should call it "auto_reconcile_specific" it is supposed to only reconcile based on the structured reference so we should also say so as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically good for me 👍
Thanks for changes.
/ocabot merge |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 2cf6a6e. Thanks a lot for contributing to OCA. ❤️ |
Replaces odoo automatic reconcile button with button, that only reconciles based on the ref.
@vrenaville can you have a look at this one? its based on the l10n-switzerland one.