[12.0][MIG] account_skip_bank_reconciliation #288

MiquelRForgeFlow · 2019-09-25T11:20:50Z

Standard migration.

account_skip_bank_reconciliation/models/account_bank_statement.py

CasVissers-360ERP · 2019-09-25T14:18:28Z

@mreficent Maybe we should also change the filename? Sorry I forgot to say that in first comment.

MiquelRForgeFlow · 2019-09-25T14:21:32Z

done 😉

CasVissers-360ERP

LGTM! Thnx!

OCA-git-bot · 2019-09-30T12:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

CasVissers-360ERP · 2019-10-07T06:44:27Z

@mreficent I think we miss an inherit here. In the filtering the accounts are filtered. But the automatic reconciliation activated when a partner is set, does still search the skip accounts. I tried to find the method myself but didn't succeed (yet).

It might be _domain_move_lines_for_manual_reconciliation and/or _get_move_line_reconciliation_proposition both methods don't have a domain for exclude_bank_reconcile.

MiquelRForgeFlow · 2019-10-07T13:05:32Z

@CasVissers can you check?

AdriaGForgeFlow

Functional test 👍

JordiBForgeFlow · 2019-10-23T09:21:21Z

/ocabot merge

OCA-git-bot · 2019-10-23T09:21:35Z

@jbeficent The merge process could not start, because of exception <class 'requests.exceptions.ReadTimeout'>: A connection-level exception occurred: HTTPSConnectionPool(host='api.github.com', port=443): Read timed out. (read timeout=10).

JordiBForgeFlow · 2020-01-22T15:54:04Z

/ocabot merge

OCA-git-bot · 2020-01-22T15:54:43Z

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-288-by-JordiBForgeFlow-bump-no, awaiting test results.

Signed-off-by JordiBForgeFlow

CasVissers-360ERP · 2020-01-22T16:25:00Z

@MiquelRForgeFlow
Sorry for the delay but it took me some time for figure out how to reproduce the usecase that didnt work. I was finally able to do it on the runbot related to this PR:
https://drive.google.com/file/d/1-zTmi7xfreF2KlSGNI648q8164wgXcZh/view

Translated using Weblate (Dutch) Currently translated at 100.0% (4 of 4 strings) Translation: account-reconcile-11.0/account-reconcile-11.0-account_skip_bank_reconciliation Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-11-0/account-reconcile-11-0-account_skip_bank_reconciliation/nl_NL/

JordiBForgeFlow · 2020-01-22T16:52:22Z

@CasVissers you are right! I just fixed that. Can you please check again? It looks good from my end

OCA-git-bot · 2020-01-22T17:03:22Z

@JordiBForgeFlow The merge process could not be finalized, because command oca-gen-addon-readme --org-name OCA --repo-name account-reconcile --branch 12.0 --addons-dir /tmp/tmpocikio84 --commit failed with output:

Traceback (most recent call last):
  File "/ocamt/lib/python3.6/site-packages/urllib3/connectionpool.py", line 603, in urlopen
    chunked=chunked)
  File "/ocamt/lib/python3.6/site-packages/urllib3/connectionpool.py", line 344, in _make_request
    self._validate_conn(conn)
  File "/ocamt/lib/python3.6/site-packages/urllib3/connectionpool.py", line 843, in _validate_conn
    conn.connect()
  File "/ocamt/lib/python3.6/site-packages/urllib3/connection.py", line 370, in connect
    ssl_context=context)
  File "/ocamt/lib/python3.6/site-packages/urllib3/util/ssl_.py", line 355, in ssl_wrap_socket
    return context.wrap_socket(sock, server_hostname=server_hostname)
  File "/usr/lib/python3.6/ssl.py", line 407, in wrap_socket
    _context=self, _session=session)
  File "/usr/lib/python3.6/ssl.py", line 817, in __init__
    self.do_handshake()
  File "/usr/lib/python3.6/ssl.py", line 1077, in do_handshake
    self._sslobj.do_handshake()
  File "/usr/lib/python3.6/ssl.py", line 689, in do_handshake
    self._sslobj.do_handshake()
ConnectionResetError: [Errno 104] Connection reset by peer

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/ocamt/lib/python3.6/site-packages/requests/adapters.py", line 449, in send
    timeout=timeout
  File "/ocamt/lib/python3.6/site-packages/urllib3/connectionpool.py", line 641, in urlopen
    _stacktrace=sys.exc_info()[2])
  File "/ocamt/lib/python3.6/site-packages/urllib3/util/retry.py", line 368, in increment
    raise six.reraise(type(error), error, _stacktrace)
  File "/ocamt/lib/python3.6/site-packages/urllib3/packages/six.py", line 685, in reraise
    raise value.with_traceback(tb)
  File "/ocamt/lib/python3.6/site-packages/urllib3/connectionpool.py", line 603, in urlopen
    chunked=chunked)
  File "/ocamt/lib/python3.6/site-packages/urllib3/connectionpool.py", line 344, in _make_request
    self._validate_conn(conn)
  File "/ocamt/lib/python3.6/site-packages/urllib3/connectionpool.py", line 843, in _validate_conn
    conn.connect()
  File "/ocamt/lib/python3.6/site-packages/urllib3/connection.py", line 370, in connect
    ssl_context=context)
  File "/ocamt/lib/python3.6/site-packages/urllib3/util/ssl_.py", line 355, in ssl_wrap_socket
    return context.wrap_socket(sock, server_hostname=server_hostname)
  File "/usr/lib/python3.6/ssl.py", line 407, in wrap_socket
    _context=self, _session=session)
  File "/usr/lib/python3.6/ssl.py", line 817, in __init__
    self.do_handshake()
  File "/usr/lib/python3.6/ssl.py", line 1077, in do_handshake
    self._sslobj.do_handshake()
  File "/usr/lib/python3.6/ssl.py", line 689, in do_handshake
    self._sslobj.do_handshake()
urllib3.exceptions.ProtocolError: ('Connection aborted.', ConnectionResetError(104, 'Connection reset by peer'))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/bin/oca-gen-addon-readme", line 11, in <module>
    load_entry_point('oca-maintainers-tools', 'console_scripts', 'oca-gen-addon-readme')()
  File "/ocamt/lib/python3.6/site-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/ocamt/lib/python3.6/site-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/ocamt/lib/python3.6/site-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/ocamt/lib/python3.6/site-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 310, in gen_addon_readme
    org_name, repo_name, branch, addon_name, addon_dir, manifest)
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 189, in gen_one_addon_readme
    runbot_id = get_runbot_ids().get(repo_name)
  File "/ocamt/src/oca-maintainers-tools/tools/runbot_ids.py", line 18, in get_runbot_ids
    repos_with_ids = requests.get(REPOS_WITH_IDS_URL).text
  File "/ocamt/lib/python3.6/site-packages/requests/api.py", line 75, in get
    return request('get', url, params=params, **kwargs)
  File "/ocamt/lib/python3.6/site-packages/requests/api.py", line 60, in request
    return session.request(method=method, url=url, **kwargs)
  File "/ocamt/lib/python3.6/site-packages/requests/sessions.py", line 533, in request
    resp = self.send(prep, **send_kwargs)
  File "/ocamt/lib/python3.6/site-packages/requests/sessions.py", line 646, in send
    r = adapter.send(request, **kwargs)
  File "/ocamt/lib/python3.6/site-packages/requests/adapters.py", line 498, in send
    raise ConnectionError(err, request=request)
requests.exceptions.ConnectionError: ('Connection aborted.', ConnectionResetError(104, 'Connection reset by peer'))

account_skip_bank_reconciliation/models/account_reconcile_model.py

CasVissers-360ERP

NIce! My last issue is fixed. Again thanks for the great module.

JordiBForgeFlow · 2020-01-23T09:54:50Z

/ocabot merge

OCA-git-bot · 2020-01-23T09:55:33Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-288-by-JordiBForgeFlow-bump-no, awaiting test results.

Signed-off-by JordiBForgeFlow

OCA-git-bot · 2020-01-23T10:08:04Z

Congratulations, your PR was merged at fcf4c89. Thanks a lot for contributing to OCA. ❤️

MiquelRForgeFlow mentioned this pull request Sep 25, 2019

[11.0][ADD] account_skip_bank_reconciliation #219

Merged

MiquelRForgeFlow force-pushed the 12.0-mig-account_skip_bank_reconciliation branch from 05f42bc to ede1c32 Compare September 25, 2019 11:49

CasVissers-360ERP suggested changes Sep 25, 2019

View reviewed changes

account_skip_bank_reconciliation/models/account_bank_statement.py Outdated Show resolved Hide resolved

MiquelRForgeFlow force-pushed the 12.0-mig-account_skip_bank_reconciliation branch from ede1c32 to eecf381 Compare September 25, 2019 14:15

MiquelRForgeFlow force-pushed the 12.0-mig-account_skip_bank_reconciliation branch from eecf381 to 5ad477d Compare September 25, 2019 14:21

CasVissers-360ERP approved these changes Sep 25, 2019

View reviewed changes

astirpe approved these changes Sep 25, 2019

View reviewed changes

OCA-git-bot added approved ready to merge labels Sep 25, 2019

MiquelRForgeFlow force-pushed the 12.0-mig-account_skip_bank_reconciliation branch from 5ad477d to c23868d Compare October 7, 2019 12:25

AdriaGForgeFlow approved these changes Oct 14, 2019

View reviewed changes

OCA-git-bot added a commit that referenced this pull request Jan 22, 2020

Merge PR #288 into 12.0

430cac3

Signed-off-by JordiBForgeFlow

MiquelRForgeFlow and others added 5 commits January 22, 2020 17:51

[ADD] account_skip_bank_reconciliation

10ec346

[UPD] README.rst

ff35154

[UPD] Update account_skip_bank_reconciliation.pot

4938bea

[UPD] README.rst

8bec9a4

JordiBForgeFlow force-pushed the 12.0-mig-account_skip_bank_reconciliation branch from c23868d to 7bf1272 Compare January 22, 2020 16:51

MiquelRForgeFlow commented Jan 22, 2020

View reviewed changes

account_skip_bank_reconciliation/models/account_reconcile_model.py Outdated Show resolved Hide resolved

JordiBForgeFlow force-pushed the 12.0-mig-account_skip_bank_reconciliation branch from 7bf1272 to 8536f1c Compare January 22, 2020 17:21

[MIG] account_skip_bank_reconciliation: Migration to 12.0

c3c5a43

MiquelRForgeFlow force-pushed the 12.0-mig-account_skip_bank_reconciliation branch from 8536f1c to c3c5a43 Compare January 22, 2020 17:23

CasVissers-360ERP approved these changes Jan 22, 2020

View reviewed changes

OCA-git-bot added a commit that referenced this pull request Jan 23, 2020

Merge PR #288 into 12.0

efe6cd4

Signed-off-by JordiBForgeFlow

OCA-git-bot merged commit c3c5a43 into OCA:12.0 Jan 23, 2020

OCA-git-bot added the merged 🎉 label Jan 23, 2020

MiquelRForgeFlow deleted the 12.0-mig-account_skip_bank_reconciliation branch January 23, 2020 10:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[12.0][MIG] account_skip_bank_reconciliation #288

[12.0][MIG] account_skip_bank_reconciliation #288

MiquelRForgeFlow commented Sep 25, 2019

CasVissers-360ERP commented Sep 25, 2019

MiquelRForgeFlow commented Sep 25, 2019

CasVissers-360ERP left a comment

OCA-git-bot commented Sep 30, 2019

CasVissers-360ERP commented Oct 7, 2019

MiquelRForgeFlow commented Oct 7, 2019

AdriaGForgeFlow left a comment

JordiBForgeFlow commented Oct 23, 2019

OCA-git-bot commented Oct 23, 2019

JordiBForgeFlow commented Jan 22, 2020

OCA-git-bot commented Jan 22, 2020

CasVissers-360ERP commented Jan 22, 2020

JordiBForgeFlow commented Jan 22, 2020

OCA-git-bot commented Jan 22, 2020

CasVissers-360ERP left a comment

JordiBForgeFlow commented Jan 23, 2020

OCA-git-bot commented Jan 23, 2020

OCA-git-bot commented Jan 23, 2020

[12.0][MIG] account_skip_bank_reconciliation #288

[12.0][MIG] account_skip_bank_reconciliation #288

Conversation

MiquelRForgeFlow commented Sep 25, 2019

CasVissers-360ERP commented Sep 25, 2019

MiquelRForgeFlow commented Sep 25, 2019

CasVissers-360ERP left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Sep 30, 2019

CasVissers-360ERP commented Oct 7, 2019

MiquelRForgeFlow commented Oct 7, 2019

AdriaGForgeFlow left a comment

Choose a reason for hiding this comment

JordiBForgeFlow commented Oct 23, 2019

OCA-git-bot commented Oct 23, 2019

JordiBForgeFlow commented Jan 22, 2020

OCA-git-bot commented Jan 22, 2020

CasVissers-360ERP commented Jan 22, 2020

JordiBForgeFlow commented Jan 22, 2020

OCA-git-bot commented Jan 22, 2020

CasVissers-360ERP left a comment

Choose a reason for hiding this comment

JordiBForgeFlow commented Jan 23, 2020

OCA-git-bot commented Jan 23, 2020

OCA-git-bot commented Jan 23, 2020