Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] account_reconcile_reconciliation_date #299

Merged
merged 1 commit into from Dec 19, 2019
Merged

[ADD] account_reconcile_reconciliation_date #299

merged 1 commit into from Dec 19, 2019

Conversation

osi-scampbell
Copy link
Contributor

This PR adds account_reconcile_reconciliation_date to the OCA/account-reconcile repo. See issue #294

@max3903 max3903 added this to the 12.0 milestone Dec 10, 2019
@max3903
Copy link
Sponsor Member

max3903 commented Dec 10, 2019

@osi-scampbell LGTM but it's missing documentation and unit tests

@max3903 max3903 requested a review from bodedra December 12, 2019 15:23
@osi-scampbell
[ADD] account_reconcile_reconciliation_date
58a4735 
[IMP] New Line EOF

[IMP] Flake8

[ADD] Documentation and Test Cases

[IMP] Flake8
@osi-scampbell osi-scampbell force-pushed the 12.0-add-account_reconcile_reconciliation_date branch from 771e9c9 to 58a4735 Compare December 12, 2019 15:26
@max3903
Copy link
Sponsor Member

max3903 commented Dec 19, 2019

/ocabot merge

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-299-by-max3903-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 19, 2019
@OCA-git-bot
Merge PR #299 into 12.0
bfe156d 
Signed-off-by max3903
@JordiBForgeFlow
Copy link
Sponsor Member

@osi-scampbell What about partial reconciliations? If you create two payments for the same invoice? As I understand the field in the invoice would show only the date of the last payment.

@OCA-git-bot
Copy link
Contributor

@max3903 your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-299-by-max3903-bump-no.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@max3903
Copy link
Sponsor Member

max3903 commented Dec 19, 2019

Hello @JordiBForgeFlow That's the requirement. @patrickrwilson may confirm.

@max3903
Copy link
Sponsor Member

max3903 commented Dec 19, 2019

/ocabot merge

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-299-by-max3903-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 19, 2019
@OCA-git-bot
Merge PR #299 into 12.0
b8631d2 
Signed-off-by max3903
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 58a4735 into OCA:12.0 Dec 19, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 90a402d. Thanks a lot for contributing to OCA. ❤️

@max3903 max3903 deleted the 12.0-add-account_reconcile_reconciliation_date branch March 17, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max3903 max3903 max3903 approved these changes

@patrickrwilson patrickrwilson patrickrwilson approved these changes

@bodedra bodedra Awaiting requested review from bodedra

Assignees

@osi-scampbell osi-scampbell

Labels
approved enhancement merged 🎉 needs review ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@osi-scampbell @max3903 @OCA-git-bot @JordiBForgeFlow @patrickrwilson