Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG] account_move_reconcile_helper #301

Merged
merged 10 commits into from
Nov 27, 2021
Merged

[13.0][MIG] account_move_reconcile_helper #301

merged 10 commits into from
Nov 27, 2021

Conversation

kittiu
Copy link
Member

@kittiu kittiu commented Jan 6, 2020 •
edited
Loading

Standard migration
This module depends on

@kittiu kittiu mentioned this pull request Jan 6, 2020
Closed
13 tasks
@kittiu kittiu changed the title [13.0][MIG] account_move_reconcile_helper [WIP] [13.0][MIG] account_move_reconcile_helper Jan 7, 2020
kittiu
kittiu commented Jan 7, 2020
View reviewed changes
account_move_reconcile_helper/tests/test_account_move_reconcile_helper.py

lines.reconcile()
# For v13, need to force compute
lines._compute_reconciled_lines()
Copy link
Member Author

@kittiu kittiu Jan 7, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the test works now, I do have a question.

While it works just fine when playing with the system.
But for test script, without forcing to _compute_reconciled_lines(), calling the line.reconcile_line_ids will not get the computed result.

        lines._compute_reconciled_lines()
  • Is this the affect of the new super optimized ORM in v13? (I experience this kind of things many times).
  • Doing the force compute in the test is right way to go?

CasVissers-360ERP
CasVissers-360ERP approved these changes Jan 15, 2020
View reviewed changes
Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, functional review

@kittiu kittiu force-pushed the 13.0-mig-account_move_reconcile_helper branch 2 times, most recently from 5790334 to 88d1135 Compare February 13, 2020 11:30
@kittiu
Copy link
Member Author

kittiu commented Feb 13, 2020

All set, ready for review :)

@kittiu kittiu force-pushed the 13.0-mig-account_move_reconcile_helper branch from 88d1135 to 6c5c6ca Compare May 6, 2020 06:03
@kittiu
Copy link
Member Author

kittiu commented May 6, 2020

Rebased

CasVissers-360ERP
CasVissers-360ERP approved these changes Aug 12, 2020
View reviewed changes
Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, functional review.

@kittiu kittiu force-pushed the 13.0-mig-account_move_reconcile_helper branch from 6c5c6ca to 455368e Compare September 3, 2020 07:36
Abranes
Abranes approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@Abranes Abranes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kittiu
Copy link
Member Author

kittiu commented Oct 27, 2020

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Sorry @kittiu you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@hildickethan hildickethan mentioned this pull request Dec 29, 2020
Merged
1 task
@ioans73
Copy link
Member

ioans73 commented Feb 24, 2021

@kittiu Can you check the conflicts please?

benwillig and others added 10 commits February 24, 2021 21:25
@benwillig @kittiu
[ADD] account_move_reconcile_helper
ffbd9a4
@oca-transbot @kittiu
OCA Transbot updated translations from Transifex
fc76967
@oca-travis @kittiu
[UPD] Update account_move_reconcile_helper.pot
ded4f63
@kittiu
[12.0][MIG] account_move_reconcile_helper
6ae943b
@oca-travis @kittiu
[UPD] Update account_move_reconcile_helper.pot
f3dab27
@OCA-git-bot @kittiu
[UPD] README.rst
2e60e77
@oca-transbot @kittiu
Update translation files
4dcdfcb 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-reconcile-12.0/account-reconcile-12.0-account_move_reconcile_helper
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-12-0/account-reconcile-12-0-account_move_reconcile_helper/
@badbole @kittiu
Translated using Weblate (Croatian)
4f494fb 
Currently translated at 100.0% (3 of 3 strings)

Translation: account-reconcile-12.0/account-reconcile-12.0-account_move_reconcile_helper
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-12-0/account-reconcile-12-0-account_move_reconcile_helper/hr/
@kittiu
[13.0][IMP] account_move_reconcile_helper: black, isort
e3428a8
@kittiu
[13.0][MIG] account_move_reconcile_helper
7b7cb42
@kittiu kittiu force-pushed the 13.0-mig-account_move_reconcile_helper branch from 455368e to 7b7cb42 Compare February 24, 2021 14:27
@kittiu
Copy link
Member Author

kittiu commented Feb 24, 2021

Rebased

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@bosd
Copy link
Contributor

bosd commented Apr 15, 2021

ping @oca/maintiners
@fclementic2c you are the psc of this repo if I am correct?

@kittiu
Copy link
Member Author

kittiu commented Jul 17, 2021

ping @fclementic2c

@dreispt
Copy link
Sponsor Member

dreispt commented Nov 27, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-301-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4afc85f into OCA:13.0 Nov 27, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 673e29c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abranes Abranes Abranes approved these changes

@alan196 alan196 alan196 approved these changes

@CasVissers-360ERP CasVissers-360ERP CasVissers-360ERP approved these changes

@ioans73 ioans73 ioans73 approved these changes

@hildickethan hildickethan hildickethan approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet