[IMP] Account reconcilation widget allows statement in open state

[LuceEasyPme]

Allow partial reconciliation for monthly bank statements.
Before PR: After importing a bank statement, you have to post it before being able to reconcile.
After PR: After importing a bank statement, you have can reconcile items, even if the statement is in open state. It allows to import a partial bank statement and reconcile the items, then import new lines in the same bank statement, and post it when the statement is complete.

Use case: our client wants to import and reconcile the items daily (so the bills are paid), even thought his official bank statement is available one a month.

cc @cvinh

[pedrobaeza]

This goes against v14 way of working, so this shouldn't be allowed.

[cvinh]

@pedrobaeza please note that when you reconcile entries, the account moves get posted at the same time... so IMHO it can be accepted...
Do you know how EE works with bank sync ? Are there daily/hourly bank statements ? How do they validate initial/ending balances in the case where they have monthly legal paper/pdf statements ?
Thanks for your help

[pedrobaeza]

The post operation makes the outstanding entries, so you can't skip them, as dashboard and so rely on these entries for showing correct data. Both OCA and enterprise fill draft statements, but for reconciling you have to post before, and then ending balance is adjusted by Odoo on the rest of the statements.

[LuceEasyPme]

Hello @pedrobaeza ,
Actually, the outstanding entries are already created, they are in draft state. When we reconcil them, they are posted.
You can see that in this video : https://www.youtube.com/watch?v=kBxx0gYMGwY&feature=youtu.be
Thank you very much for your help!
cc @alexis-via

[pedrobaeza]

I'm still reluctant of this change and possible side effects. At least, it should be configurable and disabled by default. I let others also to give their opinion. I will come back anyways in a couple of weeks after further testing.

[tv-openbig]

@LuceEasyPme @pedrobaeza In general it isn't a bad idea to work already on non posted statement lines to allow them to reconcile against open invoices before final posting of completed statement. However this scenario shows that it works with non reconciled open invoices. Does it also work as expected if we have non posted statement lines and invoices proceeded in a first step by creating a payment entry directly on the invoice (counterpart account would have to be the "Outstanding Receipts" account instead of the partners debit account automatically proposed in your video) ?

[pedrobaeza]

I think it can be acceptable if put it as configurable.

[cvinh]

I think it can be acceptable if put it as configurable.

Good idea

[cvinh]

Does it also work as expected if we have non posted statement lines and invoices proceeded in a first step by creating a payment entry directly on the invoice (counterpart account would have to be the "Outstanding Receipts" account instead of the partners debit account automatically proposed in your video) ?

You are right, it has to be tested

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.