New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][14.0][IMP] account_reconciliation_widget: Use in_payment #459
[WIP][14.0][IMP] account_reconciliation_widget: Use in_payment #459
Conversation
This was forced to "paid" on community, but we can make use of the feature. See https://github.com/odoo/odoo/blob/c8c3c133385a36460f3da7ed00b59116c9bcf693/addons/account/models/account_move.py#L1346-L1348 for more info.
1b240c9
to
42345f3
Compare
Tests mustn't check things that are outside the scope of its module, as things may break without having anything to do with the module itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Maybe a better way would be enable this state in a separated module / add a dependency. But, in the other way, if another module needs this state can override this method too...Itś OK. Thanks @pedrobaeza
I'm still seeing the consequences, and yes, I will probably put not a separate module, but an option like the one in journals. Now Odoo always consider |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
To skip the in_payment state and have 2 moves (bank->payable->expense) instead of 3 (bank->outstanding->payable->expense), one need to set the outstanding accounts to the bank account. When you use register payment with this setup, you a got fully paid invoice directly. I think that's the correct behavior |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and Functional review OK ! Thanks !
Maybe you should add some docs for the journal configuration and reconciliation workflows
This is still WIP |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
@pedrobaeza Are you planning to continue with this PR? What do you think about implementing it in a separate module? If that's the case, I can do it and submit a PR. What do you think? And if you have a name suggestion, I appreciate it. |
Still in my TODO, but I think it can be in the same module. If you can take a look, please tell us. |
This was forced to "paid" on community, but we can make use of the feature.
See https://github.com/odoo/odoo/blob/c8c3c133385a36460f3da7ed00b59116c9bcf693/addons/account/models/account_move.py#L1346-L1348 for more info.