Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][14.0][IMP] account_reconciliation_widget: Use in_payment #459

Conversation

pedrobaeza
Copy link
Member

This was forced to "paid" on community, but we can make use of the feature.

See https://github.com/odoo/odoo/blob/c8c3c133385a36460f3da7ed00b59116c9bcf693/addons/account/models/account_move.py#L1346-L1348 for more info.

@pedrobaeza pedrobaeza added this to the 14.0 milestone Apr 18, 2022
@pedrobaeza pedrobaeza force-pushed the 14.0-account_reconciliation_widget-in_payment branch from 1b240c9 to 42345f3 Compare April 18, 2022 08:05
Tests mustn't check things that are outside the scope of its module,
as things may break without having anything to do with the module
itself.
Copy link
Contributor

@ozono ozono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe a better way would be enable this state in a separated module / add a dependency. But, in the other way, if another module needs this state can override this method too...Itś OK. Thanks @pedrobaeza

@pedrobaeza
Copy link
Member Author

I'm still seeing the consequences, and yes, I will probably put not a separate module, but an option like the one in journals. Now Odoo always consider in_payment state when registering payments, so that leads to "non finished" flows without reconciliation, so I don't like it too much, but as said, I'm yet gathering all the information.

@OSevangelist

This comment was marked as resolved.

@pedrobaeza

This comment was marked as resolved.

@OSevangelist

This comment was marked as resolved.

@TeoGoddet
Copy link
Contributor

TeoGoddet commented May 3, 2022

To skip the in_payment state and have 2 moves (bank->payable->expense) instead of 3 (bank->outstanding->payable->expense), one need to set the outstanding accounts to the bank account.
image
image

When you use register payment with this setup, you a got fully paid invoice directly.
See this invoice http://oca-account-reconcile-14-0-pr459-66f35e640d49.runboat.odoo-community.org/web#id=11&action=207&model=account.move&view_type=form&cids=&menu_id=107 (check the cash account config)

Vs this one http://oca-account-reconcile-14-0-pr459-66f35e640d49.runboat.odoo-community.org/web#id=12&action=209&model=account.move&view_type=form&cids=&menu_id=107

I think that's the correct behavior

Copy link
Contributor

@TeoGoddet TeoGoddet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and Functional review OK ! Thanks !
Maybe you should add some docs for the journal configuration and reconciliation workflows

@pedrobaeza pedrobaeza changed the title [14.0][IMP] account_reconciliation_widget: Use in_payment [WIP][14.0][IMP] account_reconciliation_widget: Use in_payment May 3, 2022
@pedrobaeza
Copy link
Member Author

This is still WIP

@github-actions
Copy link

github-actions bot commented Feb 5, 2023

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 5, 2023
@github-actions github-actions bot closed this Mar 12, 2023
@marcelsavegnago
Copy link
Member

@pedrobaeza Are you planning to continue with this PR?

What do you think about implementing it in a separate module? If that's the case, I can do it and submit a PR. What do you think? And if you have a name suggestion, I appreciate it.

@pedrobaeza
Copy link
Member Author

Still in my TODO, but I think it can be in the same module. If you can take a look, please tell us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved stale PR/Issue without recent activity, it'll be soon closed automatically. work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants