[16.0][MIG] agreement_rebate: Migration to version 16.0 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan-tecnativa
force-pushed
the
16.0-mig-agreement_rebate
branch
from
87c9ffd
to
7ba36c8
Compare
CarlosRoca13
suggested changes
Jul 20, 2023
| invoice_line._onchange_product_id() | ||
| invoice_line.name = invoice_line._compute_name() |
There was a problem hiding this comment.
The thing is that when trying to create the invoice, I was getting an error regarding to invoice_line_vals["name"] does not exist , and what i deducted is that apparently some of the computes weren't acting. By manually invoking the compute this name value is updated and other fields also appear after the executing of the next line. This is a solution that I found, but not sure if it is the best or if there is a better aproach to this.
|
There's already #21 |
Ups, it wasn't the first time I look for this migration. I am revising it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT44312
@sergio-teruel @CarlosRoca13 please review!