Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

11.0 Improvement for filters and product page description #14

Merged
merged 5 commits into from
Oct 2, 2018
Merged

11.0 Improvement for filters and product page description #14

merged 5 commits into from
Oct 2, 2018

Conversation

bizzappdev
Copy link

Improvements:

  1. Image problem for module description
  2. Remove Author Filter.
  3. add "All" version in filter

@bizzappdev
Copy link
Author

cc @elicoidal @oscarolar

elicoidal
elicoidal approved these changes Oct 1, 2018
View reviewed changes
Copy link

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of questions but overall good to me.
Shall we bump version number? (not live in OCA but other organization might have)

apps_product_creator/models/product_product.py
return "/".join(map(lambda x: str(x).rstrip('/'), args))


def hook_github_image_url(rst_desc, github_url):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why hook_?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is literally processing the URL and adding GitHub module prefix URL for display purpose.

apps_product_creator/models/product_product.py
@api.multi
def _compute_rst_html_desc(self):
for product in self:
rst_desc = product.odoo_module_version_id.description_rst_html
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that description_rst_html will already contain either html if exist or rst as fallback.
Do you confirm?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elicoidal yes it will. confirmed with https://github.com/OCA/server-tools/blob/11.0/base_fontawesome/ module and it is working

@elicoidal elicoidal added this to the 11.0 milestone Oct 1, 2018
@bizzappdev
Copy link
Author

@RoelAdriaans can you please review

@bizzappdev
Copy link
Author

@pedrobaeza can you please review and then merge.

RoelAdriaans
RoelAdriaans suggested changes Oct 2, 2018
View reviewed changes
Copy link

@RoelAdriaans RoelAdriaans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test_select_author_search_tour test has to be removed before travis turns green.
Filter is removed, but test isn't.. :)

@elicoidal
Copy link

Please check Travis.

@bizzappdev
Copy link
Author

@RoelAdriaans Thanks for noticing. Did commit for the removing test case for the author.
let's wait for Travis result.
cc @elicoidal

@bizzappdev
Copy link
Author

@moylop260 can you please review, I have developed as per your suggestion.

@RoelAdriaans
Copy link

@elicoidal Travis is green now

@bizzappdev
Copy link
Author

@pedrobaeza @elicoidal Can you please take care for merging?

@elicoidal elicoidal merged commit 6d1da75 into OCA:11.0 Oct 2, 2018
victormmtorres pushed a commit to Tecnativa/apps-store that referenced this pull request Apr 10, 2019
@bizzappdev
11.0 Improvement for filters and product page description (OCA#14)
7d5aeeb 
* [IMP] website_apps_store: remove author filter from shop

* [FIX]apps_product_creator: fix the broken image path problem with github direct link

* [FIX]rename method with proper name

* [FIX] solve the problem for renaming function

* [FIX] reoved the author test cases
victormmtorres pushed a commit to Tecnativa/apps-store that referenced this pull request Apr 30, 2019
@bizzappdev
11.0 Improvement for filters and product page description (OCA#14)
c8cd290 
* [IMP] website_apps_store: remove author filter from shop

* [FIX]apps_product_creator: fix the broken image path problem with github direct link

* [FIX]rename method with proper name

* [FIX] solve the problem for renaming function

* [FIX] reoved the author test cases
victormmtorres pushed a commit to Tecnativa/apps-store that referenced this pull request May 2, 2019
@bizzappdev
11.0 Improvement for filters and product page description (OCA#14)
afeb806 
* [IMP] website_apps_store: remove author filter from shop

* [FIX]apps_product_creator: fix the broken image path problem with github direct link

* [FIX]rename method with proper name

* [FIX] solve the problem for renaming function

* [FIX] reoved the author test cases
victormmtorres pushed a commit to Tecnativa/apps-store that referenced this pull request May 6, 2019
@bizzappdev
11.0 Improvement for filters and product page description (OCA#14)
693a96f 
* [IMP] website_apps_store: remove author filter from shop

* [FIX]apps_product_creator: fix the broken image path problem with github direct link

* [FIX]rename method with proper name

* [FIX] solve the problem for renaming function

* [FIX] reoved the author test cases
CarlosRoca13 pushed a commit to Tecnativa/apps-store that referenced this pull request Jul 10, 2020
@bizzappdev @CarlosRoca13
11.0 Improvement for filters and product page description (OCA#14)
3b258e1 
* [IMP] website_apps_store: remove author filter from shop

* [FIX]apps_product_creator: fix the broken image path problem with github direct link

* [FIX]rename method with proper name

* [FIX] solve the problem for renaming function

* [FIX] reoved the author test cases
Tardo pushed a commit to Tecnativa/apps-store that referenced this pull request Aug 5, 2020
@bizzappdev @Tardo
11.0 Improvement for filters and product page description (OCA#14)
2a93c58 
* [IMP] website_apps_store: remove author filter from shop

* [FIX]apps_product_creator: fix the broken image path problem with github direct link

* [FIX]rename method with proper name

* [FIX] solve the problem for renaming function

* [FIX] reoved the author test cases
pedrobaeza pushed a commit to Tecnativa/apps-store that referenced this pull request Aug 12, 2020
@bizzappdev @pedrobaeza
11.0 Improvement for filters and product page description (OCA#14)
438547f 
* [IMP] website_apps_store: remove author filter from shop

* [FIX]apps_product_creator: fix the broken image path problem with github direct link

* [FIX]rename method with proper name

* [FIX] solve the problem for renaming function

* [FIX] reoved the author test cases
ernestotejeda pushed a commit to Tecnativa/apps-store that referenced this pull request Aug 2, 2021
@bizzappdev
11.0 Improvement for filters and product page description (OCA#14)
fc36024 
* [IMP] website_apps_store: remove author filter from shop

* [FIX]apps_product_creator: fix the broken image path problem with github direct link

* [FIX]rename method with proper name

* [FIX] solve the problem for renaming function

* [FIX] reoved the author test cases
ernestotejeda pushed a commit to Tecnativa/apps-store that referenced this pull request Aug 16, 2021
@bizzappdev
11.0 Improvement for filters and product page description (OCA#14)
63d8300 
* [IMP] website_apps_store: remove author filter from shop

* [FIX]apps_product_creator: fix the broken image path problem with github direct link

* [FIX]rename method with proper name

* [FIX] solve the problem for renaming function

* [FIX] reoved the author test cases
ernestotejeda pushed a commit to Tecnativa/apps-store that referenced this pull request Aug 24, 2021
@bizzappdev
11.0 Improvement for filters and product page description (OCA#14)
261c076 
* [IMP] website_apps_store: remove author filter from shop

* [FIX]apps_product_creator: fix the broken image path problem with github direct link

* [FIX]rename method with proper name

* [FIX] solve the problem for renaming function

* [FIX] reoved the author test cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanRozendaal StephanRozendaal StephanRozendaal approved these changes

@elicoidal elicoidal elicoidal approved these changes

@RoelAdriaans RoelAdriaans RoelAdriaans approved these changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bizzappdev @elicoidal @RoelAdriaans @StephanRozendaal