Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] apps-store #15

Merged
merged 3 commits into from
Oct 2, 2018
Merged

[IMP] apps-store #15

merged 3 commits into from
Oct 2, 2018

Conversation

oscarolar
Copy link

  • Shop:

    • Removed filter by author.
    • Added a more informative placeholder to the searchbox
    • Added categories of apps to public categories.
    • Added a filter All option for categories dropdown.
    • Removed sort by price.

  • Changed the way products are created, now products are related
    to their correspondant category. (used the ones from Odoo.com/apps)

  • On PDP added the version of the app if it has no variants.

@oscarolar
Copy link
Author

cc @bizzappdev @elicoidal

elicoidal
elicoidal approved these changes Oct 1, 2018
View reviewed changes
Copy link

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Might bump the version number

@elicoidal elicoidal added this to the 11.0 milestone Oct 1, 2018
@oscarolar
[IMP] apps-store:
fd02803 
- Shop:
  * Removed filter by author.
  * Added a more informative placeholder to the searchbox
  * Added categories of apps to public categories.
  * Added a filter `All` option for categories dropdown.
  * Removed sort by price.

- Changed the way products are created, now products are related
to their correspondant category. (used the ones from Odoo.com/apps)

- On PDP added the version of the app if it has no variants.
@elicoidal
Copy link

Please check Travis.

@bizzappdev bizzappdev mentioned this pull request Oct 2, 2018
Merged
@oscarolar
Copy link
Author

To make the test pass
depends: OCA/interface-github#22

bizzappdev
bizzappdev suggested changes Oct 2, 2018
View reviewed changes
Copy link

@bizzappdev bizzappdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only last thing for supporting "Other" category if it is not able to find the category based on module version category.

apps_product_creator/models/odoo_module.py Outdated
@@ -93,6 +93,9 @@ def _prepare_template(self):
'attribute_id': attribute.id,
'value_ids': [(6, 0, attributes.ids)],
}
version_categ = self.module_version_ids.mapped('category_id')
category = self.env['product.public.category'].search(
[('name','=',version_categ.name)], limit=1)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oscarolar don't your thing that we need to add Other as a category in case we are not able to find a website category based on version category.

bizzappdev
bizzappdev approved these changes Oct 2, 2018
View reviewed changes
Copy link

@bizzappdev bizzappdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elicoidal
Copy link

Please fix conflicts

@elicoidal elicoidal merged commit a45dfac into OCA:11.0 Oct 2, 2018
victormmtorres pushed a commit to Tecnativa/apps-store that referenced this pull request Apr 10, 2019
@oscarolar
[IMP] apps-store (OCA#15)
93d9b07 
* [IMP] apps-store:

- Shop:
  * Removed filter by author.
  * Added a more informative placeholder to the searchbox
  * Added categories of apps to public categories.
  * Added a filter `All` option for categories dropdown.
  * Removed sort by price.

- Changed the way products are created, now products are related
to their correspondant category. (used the ones from Odoo.com/apps)

- On PDP added the version of the app if it has no variants.

* [REF] if no category found will defailt to 'Other' category
victormmtorres pushed a commit to Tecnativa/apps-store that referenced this pull request Apr 30, 2019
@oscarolar
[IMP] apps-store (OCA#15)
f1cbbbd 
* [IMP] apps-store:

- Shop:
  * Removed filter by author.
  * Added a more informative placeholder to the searchbox
  * Added categories of apps to public categories.
  * Added a filter `All` option for categories dropdown.
  * Removed sort by price.

- Changed the way products are created, now products are related
to their correspondant category. (used the ones from Odoo.com/apps)

- On PDP added the version of the app if it has no variants.

* [REF] if no category found will defailt to 'Other' category
victormmtorres pushed a commit to Tecnativa/apps-store that referenced this pull request May 2, 2019
@oscarolar
[IMP] apps-store (OCA#15)
cb1a64e 
* [IMP] apps-store:

- Shop:
  * Removed filter by author.
  * Added a more informative placeholder to the searchbox
  * Added categories of apps to public categories.
  * Added a filter `All` option for categories dropdown.
  * Removed sort by price.

- Changed the way products are created, now products are related
to their correspondant category. (used the ones from Odoo.com/apps)

- On PDP added the version of the app if it has no variants.

* [REF] if no category found will defailt to 'Other' category
victormmtorres pushed a commit to Tecnativa/apps-store that referenced this pull request May 6, 2019
@oscarolar
[IMP] apps-store (OCA#15)
a59fe37 
* [IMP] apps-store:

- Shop:
  * Removed filter by author.
  * Added a more informative placeholder to the searchbox
  * Added categories of apps to public categories.
  * Added a filter `All` option for categories dropdown.
  * Removed sort by price.

- Changed the way products are created, now products are related
to their correspondant category. (used the ones from Odoo.com/apps)

- On PDP added the version of the app if it has no variants.

* [REF] if no category found will defailt to 'Other' category
CarlosRoca13 pushed a commit to Tecnativa/apps-store that referenced this pull request Jul 10, 2020
@oscarolar @CarlosRoca13
[IMP] apps-store (OCA#15)
a1f02cf 
* [IMP] apps-store:

- Shop:
  * Removed filter by author.
  * Added a more informative placeholder to the searchbox
  * Added categories of apps to public categories.
  * Added a filter `All` option for categories dropdown.
  * Removed sort by price.

- Changed the way products are created, now products are related
to their correspondant category. (used the ones from Odoo.com/apps)

- On PDP added the version of the app if it has no variants.

* [REF] if no category found will defailt to 'Other' category
Tardo pushed a commit to Tecnativa/apps-store that referenced this pull request Aug 5, 2020
@oscarolar @Tardo
[IMP] apps-store (OCA#15)
f8e0431 
* [IMP] apps-store:

- Shop:
  * Removed filter by author.
  * Added a more informative placeholder to the searchbox
  * Added categories of apps to public categories.
  * Added a filter `All` option for categories dropdown.
  * Removed sort by price.

- Changed the way products are created, now products are related
to their correspondant category. (used the ones from Odoo.com/apps)

- On PDP added the version of the app if it has no variants.

* [REF] if no category found will defailt to 'Other' category
pedrobaeza pushed a commit to Tecnativa/apps-store that referenced this pull request Aug 12, 2020
@oscarolar @pedrobaeza
[IMP] apps-store (OCA#15)
8bcc0b2 
* [IMP] apps-store:

- Shop:
  * Removed filter by author.
  * Added a more informative placeholder to the searchbox
  * Added categories of apps to public categories.
  * Added a filter `All` option for categories dropdown.
  * Removed sort by price.

- Changed the way products are created, now products are related
to their correspondant category. (used the ones from Odoo.com/apps)

- On PDP added the version of the app if it has no variants.

* [REF] if no category found will defailt to 'Other' category
ernestotejeda pushed a commit to Tecnativa/apps-store that referenced this pull request Aug 2, 2021
@oscarolar
[IMP] apps-store (OCA#15)
4bbf814 
* [IMP] apps-store:

- Shop:
  * Removed filter by author.
  * Added a more informative placeholder to the searchbox
  * Added categories of apps to public categories.
  * Added a filter `All` option for categories dropdown.
  * Removed sort by price.

- Changed the way products are created, now products are related
to their correspondant category. (used the ones from Odoo.com/apps)

- On PDP added the version of the app if it has no variants.

* [REF] if no category found will defailt to 'Other' category
ernestotejeda pushed a commit to Tecnativa/apps-store that referenced this pull request Aug 16, 2021
@oscarolar
[IMP] apps-store (OCA#15)
fb2e66e 
* [IMP] apps-store:

- Shop:
  * Removed filter by author.
  * Added a more informative placeholder to the searchbox
  * Added categories of apps to public categories.
  * Added a filter `All` option for categories dropdown.
  * Removed sort by price.

- Changed the way products are created, now products are related
to their correspondant category. (used the ones from Odoo.com/apps)

- On PDP added the version of the app if it has no variants.

* [REF] if no category found will defailt to 'Other' category
ernestotejeda pushed a commit to Tecnativa/apps-store that referenced this pull request Aug 24, 2021
@oscarolar
[IMP] apps-store (OCA#15)
a78d3cb 
* [IMP] apps-store:

- Shop:
  * Removed filter by author.
  * Added a more informative placeholder to the searchbox
  * Added categories of apps to public categories.
  * Added a filter `All` option for categories dropdown.
  * Removed sort by price.

- Changed the way products are created, now products are related
to their correspondant category. (used the ones from Odoo.com/apps)

- On PDP added the version of the app if it has no variants.

* [REF] if no category found will defailt to 'Other' category
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanRozendaal StephanRozendaal StephanRozendaal approved these changes

@bizzappdev bizzappdev bizzappdev approved these changes

@elicoidal elicoidal elicoidal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oscarolar @elicoidal @StephanRozendaal @bizzappdev