Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] website_apps_store: improved download button #16

Merged
merged 2 commits into from
Oct 1, 2018

Conversation

oscarolar
Copy link

Before
image

After
image

@oscarolar
Copy link
Author

cc @elicoidal

Copy link

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version number.
LGTM

<div class="col-xs-4 zip_button">
<button name="download_zip" id="download_zip" t-att-data-tmpl-id="product.id">Download</button>
<div class="col-xs-4 mt16 mb16">
<button class="btn btn-primary btn-lg" name="download_zip" id="download_zip" t-att-data-tmpl-id="product.id">Download <span class="fa fa-download"/></button>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please improve the format for readability purpose.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elicoidal done

@pedrobaeza pedrobaeza added this to the 11.0 milestone Oct 1, 2018
@pedrobaeza pedrobaeza merged commit eaa8585 into OCA:11.0 Oct 1, 2018
victormmtorres pushed a commit to Tecnativa/apps-store that referenced this pull request Apr 30, 2019
victormmtorres pushed a commit to Tecnativa/apps-store that referenced this pull request May 2, 2019
victormmtorres pushed a commit to Tecnativa/apps-store that referenced this pull request May 6, 2019
Tardo pushed a commit to Tecnativa/apps-store that referenced this pull request Aug 5, 2020
pedrobaeza pushed a commit to Tecnativa/apps-store that referenced this pull request Aug 12, 2020
ernestotejeda pushed a commit to Tecnativa/apps-store that referenced this pull request Aug 16, 2021
ernestotejeda pushed a commit to Tecnativa/apps-store that referenced this pull request Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants