Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][IMP] website_apps_store: Bootstrap and Javascript #67

Merged
merged 2 commits into from Aug 23, 2019

Conversation

Tardo
Copy link
Member

@Tardo Tardo commented Aug 23, 2019

  • Uses Bootstrap 4
  • Adapted Javascript to new API

screenshot_20190823-142033_1920x1080

screenshot_20190823-142113_1920x1080

Cc @Tecnativa

@pedrobaeza pedrobaeza added this to the 12.0 milestone Aug 23, 2019
@Tardo Tardo force-pushed the 12.0-imp-website_apps_store branch 2 times, most recently from 0e97533 to b8195b8 Compare August 23, 2019 15:17
@@ -149,26 +149,6 @@ def shop(self, page=0, category=None, search='', ppg=False, **post):
})
return res

@http.route(['/shop/change_attribute_version'], type='json',
auth="public", website=True)
def change_product_attribute_version(self, **kwargs):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to know the reason of this change. Code is supersede or just was unnecessary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tardo Tardo force-pushed the 12.0-imp-website_apps_store branch from b8195b8 to 598da7b Compare August 23, 2019 16:29
Copy link

@victormmtorres victormmtorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM functional tested on Runbot

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried and working on OCA instance

@pedrobaeza
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Rebased to 12.0-ocabot-merge-pr-67-by-pedrobaeza-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Aug 23, 2019
Signed-off-by pedrobaeza
@OCA-git-bot OCA-git-bot merged commit 598da7b into OCA:12.0 Aug 23, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 485c510. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 12.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants