[11.0][MIG] apps_product_creator: Migration to 11.0 #9
Conversation
- Renamed attribute names on product.product model; - Removed some unused attribute definition on product.product model; - Attribute image_module on product.template is now not stored; - Views definition made compliant with OCA guidelines; - Added values 5, 6, 6.1, 7 and 11 to product attribute Odoo Version; - On odoo.module form views, replaced "Create Products" with Smartbutton for showing related product variants; - Products created from modules are now set as not purchasable and with 0 cost and sell price; - Rearranged product.product view definition in "Module Informations" tab;
.idea/apps-store.iml
Outdated
| @@ -0,0 +1,11 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
please remove this file or edit gitignore
| <!--License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).--> | ||
| <odoo noupdate="1"> | ||
|
|
||
| <record id="attribute_odoo_version" model="product.attribute"> |
There was a problem hiding this comment.
Following #8 (comment) should be data not demo
| <field name="product_template_id"/> | ||
| </xpath> | ||
| <xpath expr="//div[@name='button_box']" position="inside"> | ||
| <button type="object" class="oe_stat_button" icon="fa-arrows-v" name="action_view_products" attrs="{'invisible': [('product_qty', '=', 0)]}"> |
There was a problem hiding this comment.
can you improve the format for readability?
| <field name="inherit_id" ref="product.product_normal_form_view"/> | ||
| <field name="arch" type="xml"> | ||
| <xpath expr="//notebook" position="inside"> | ||
| <page string="Module Informations" id="module_informations" attrs="{'invisible':[('odoo_module_version_id','=',False)]}"> |
|
@elicoidal Thanks for your review! I applied the improvements. |
|
Please take care of travis too |
|
@tafaRU @espo-tony @hurrinico @acsonefho can you help review here? |
|
Code LGTM (not tested) |
|
thanks for the review @acsonefho ! |
|
Code LGTM too. |
|
Not sure who could help in the testing, any idea? |
|
Add file |
|
@astirpe It turned green, thanks!! |
|
@tarteo just a note we have changed few things in V10 in https://github.com/OCA/apps-store/pull/10/files which might later have to be migrated also. |
|
@elicoidal is this ready for merge? \cc @jgrandguillaume |
|
Yep |
Depends on OCA/interface-github#9