8.0 improve selection of invoices to pay, solves #93 #110

sbidoul · 2015-01-22T17:04:16Z

This PR has already been extensively discussed in acsone#5.

It provides:

an improvement of the criteria to select invoices to pay
a button on payment orders with transfer moves to show the partially reconciled transfer moves in one click, therefore providing a path to reconcile and writeoff such partial payments; this is particularly useful in the presence of cash discount and fixes Problem adding partially reconciled moves to a payment order #93

pedrobaeza · 2015-01-22T23:34:42Z

account_banking_payment_export/wizard/payment_order_create.py

@@ -45,9 +46,33 @@ def default_get(self, field_list):
    def extend_payment_order_domain(self, payment_order, domain):
        if payment_order.payment_order_type == 'payment':
            domain += [('account_id.type', 'in', ('payable', 'receivable')),
-                       ('amount_to_pay', '>', 0)]
+                       ('credit', '>', 0)]


This is the main reason why we can't add refunds. We can redo this making:

... '|', '&', ('credit', '>', '0'), ('type', '=', 'in_invoice'), '&', ('credit', '<', '0'), ('type', '=', 'in_refund')]

Can you elaborate the scenario that causes problems for you? In my understanding credit or debit can never be negative in Odoo.

So we have the following:

supplier invoice: credit > 0 on payable account

supplier refund: not something to be paid on a credit transfer order

customer invoice: not something to be paid on a credit transfer order

customer refund: credit > 0 on receivable account

alexis-via · 2015-01-25T00:45:17Z

@sbidoul I tested your PR and it works well.

But I have a question: I see you added a button "Partial reconciles counter" on payment order to see the number of lines that you need to reconcile manually. Don't you think that we should be able to do it automatically ? I mean, if I have the module account_banking_payment_transfer:

I create a supplier invoice amount 100 for agrolait
I create a supplier refund amount 20 for agrolait
I partially reconcile the invoice and refund (reconcile mark A1)
I create a payment order and I select the account move line of the invoice of agrolait: it creates a payment line of 80 => your PR does that very well.
when I valiade the payment order, an account move will be generated from agrolait's supplier account to the transfer account for an amount of 80. We should be able to delete the reconcile mark A1 and re-create a new reconcile mark A2 with the same lines as A1 plus the line of the transfer move: if all the lines of the reconcile mark A2 are balanced, A2 will be a "full reconcile" mark (it is the case in this scenario) ; otherwise, A2 will be a partial reconcile mark (like A1), and we will be able to select the invoice again in another payment order to pay the residual.

I think it is possible to develop that. And I think it's what accountants would expect. I can help you implement that if you think it's possible.

sbidoul · 2015-01-25T11:56:31Z

Hi Alexis,

Yes the scenario you describe in 5) should be automatic. Actually, I thought it was the case already. So if it's not we should develop it (in another PR I suppose).

But the scenario that led us to create that button is the following (see also #101):

accountant selects invoice to pay
accountant modifies the amount to pay on the payment line because he can benefit from a discount for early payment (actually, we are preparting a set of modules that help doing that)
the system does the transfer move and a partial reconcile with the invoice
the residual amount must be put on an income account: the new button introduced in this PR is there to facilitate that by giving one click access to the partially reconciled transfer moves so the user can do the write-off easily and make sure the invoice will not be proposed again for payment

adrienpeiffer · 2015-01-29T15:46:22Z

@alexis-via changes in b5e571f allow automatic reconciliation with the transfer move even if move line linked on the payment line is already partially reconciled

matthieuchoplin · 2015-03-02T09:46:27Z

Hi,
thanks for your work.
I would like to add some tests in the same idea of this PR: #136 according to the test scenario described by @alexis-via above.
I cannot checkout this PR at the moment (because of write access). Do you know an other way to do it?
I think that with automated tests, it will be easier to decide to merge a PRs.
What do you think?

sbidoul · 2015-03-02T10:27:58Z

@matthieuchoplin thanks a lot for proposing to add test. This is most welcome.

Since the test you propose is specific to this PR, I suggest you do it as a PR to branch acsone:8.0-bank-payment-fix93-sbi. I'll review it and merge it into this PR.

sbidoul · 2015-03-04T10:16:04Z

I committed a more sophisticated filter on receivables to filter out partially reconciled customer credit notes.

And rebased to get the latest pep8 fixes.

…e use case given in OCA#93

matthieuchoplin · 2015-03-06T10:39:40Z

Test have been proposed for the use case stated in #93 here acsone#6

This fixes OCA#93. - filter invoices that are already in draft and open payment orders. - use residual amount to care for partial reconciliations and align with official 8.0

… order

…nciled then write new values on this partial reconcile

…payment without refund

sbidoul · 2015-03-06T17:23:18Z

The tests from @matthieuchoplin are merged and I rebased.

sbidoul · 2015-03-09T09:13:02Z

@pedrobaeza @alexis-via your comments have been cared for. This is working fine in production at several customers. Looking forward to your reviews.

matthieuchoplin · 2015-03-11T13:24:30Z

I would be happy to have this one merged and carry on the improvements in other PRs.
@pedrobaeza : do you still have concern regarding the selection of customer credit notes?
If so, I am not sure about the use case to test, could you please write it here?
Thanks

pedrobaeza · 2015-03-13T01:28:51Z

Well, for now it can be merged by my part, because I need to go deeper to solve my problem, but there's not related to this PR.

👍

Let's see if @alexis-via also agrees about merging.

matthieuchoplin · 2015-04-07T11:38:08Z

Hi,
FYI, I am also using this code in production.
@alexis-via: do you agree for merging this branch into OCA:8.0?

alexis-via · 2015-04-07T14:27:14Z

yes, let's go 👍

8.0 improve selection of invoices to pay, solves #93

sbidoul added 8.0 enhancement needs review labels Jan 22, 2015

sbidoul force-pushed the 8.0-bank-payment-fix93-sbi branch from 5a6dcdc to cb02532 Compare January 22, 2015 17:13

pedrobaeza reviewed Jan 22, 2015
View reviewed changes

sbidoul mentioned this pull request Feb 27, 2015

This module will make the invoice paid when you finish the payment order workflow #132

Closed

sbidoul force-pushed the 8.0-bank-payment-fix93-sbi branch from 7e1fc25 to b3c7061 Compare March 4, 2015 10:15

[test_for_account_banking_payment_transfer] add tests according to th…

19ebc1e

…e use case given in OCA#93

This was referenced Mar 6, 2015

Problem adding partially reconciled moves to a payment order #93

Closed

Yml test for a simple invoice to payment flow #136

Closed

sbidoul mentioned this pull request Mar 6, 2015

Test for account banking payment transfer acsone/bank-payment#6

Merged

sbidoul and others added 5 commits March 6, 2015 18:19

[IMP] improve selection of invoices to pay

0f91f27

This fixes OCA#93. - filter invoices that are already in draft and open payment orders. - use residual amount to care for partial reconciliations and align with official 8.0

[ADD] Add the possibility to show partial reconcilations from payment…

2919623

… order

[FIX] If move line linked with payment line is already partially reco…

bc19e18

…nciled then write new values on this partial reconcile

[IMP] improve selection of customer credit notes to pay

c288d62

[test_for_account_banking_payment_transfer] add test for the partial …

0e02b7e

…payment without refund

sbidoul force-pushed the 8.0-bank-payment-fix93-sbi branch from 830b27d to 0e02b7e Compare March 6, 2015 17:21

adrienpeiffer mentioned this pull request Mar 24, 2015

[FIX] account_banking_payment_transfer: Error reference to partial recon... #149

Closed

pedrobaeza added a commit that referenced this pull request Apr 8, 2015

Merge pull request #110 from acsone/8.0-bank-payment-fix93-sbi

723d7e8

8.0 improve selection of invoices to pay, solves #93

pedrobaeza merged commit 723d7e8 into OCA:8.0 Apr 8, 2015

sbidoul deleted the 8.0-bank-payment-fix93-sbi branch April 13, 2015 14:06

sbidoul mentioned this pull request Sep 24, 2015

[8.0][IMP] Adapt the filter selecting invoices to pay #215

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8.0 improve selection of invoices to pay, solves #93 #110

8.0 improve selection of invoices to pay, solves #93 #110

sbidoul commented Jan 22, 2015

pedrobaeza Jan 22, 2015

sbidoul Jan 23, 2015

alexis-via commented Jan 25, 2015

sbidoul commented Jan 25, 2015

adrienpeiffer commented Jan 29, 2015

matthieuchoplin commented Mar 2, 2015

sbidoul commented Mar 2, 2015

sbidoul commented Mar 4, 2015

matthieuchoplin commented Mar 6, 2015

sbidoul commented Mar 6, 2015

sbidoul commented Mar 9, 2015

matthieuchoplin commented Mar 11, 2015

pedrobaeza commented Mar 13, 2015

matthieuchoplin commented Apr 7, 2015

alexis-via commented Apr 7, 2015

8.0 improve selection of invoices to pay, solves #93 #110

8.0 improve selection of invoices to pay, solves #93 #110

Conversation

sbidoul commented Jan 22, 2015

pedrobaeza Jan 22, 2015

Choose a reason for hiding this comment

sbidoul Jan 23, 2015

Choose a reason for hiding this comment

alexis-via commented Jan 25, 2015

sbidoul commented Jan 25, 2015

adrienpeiffer commented Jan 29, 2015

matthieuchoplin commented Mar 2, 2015

sbidoul commented Mar 2, 2015

sbidoul commented Mar 4, 2015

matthieuchoplin commented Mar 6, 2015

sbidoul commented Mar 6, 2015

sbidoul commented Mar 9, 2015

matthieuchoplin commented Mar 11, 2015

pedrobaeza commented Mar 13, 2015

matthieuchoplin commented Apr 7, 2015

alexis-via commented Apr 7, 2015