Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[account_banking_tests_fix_137] deprecation and dependancies #138

Merged
merged 2 commits into from
Mar 5, 2015
Merged

[account_banking_tests_fix_137] deprecation and dependancies #138

merged 2 commits into from
Mar 5, 2015

Conversation

matthieuchoplin
Copy link

Small modification to avoid error and warning reported in #137

@pedrobaeza
Copy link
Member

👍

1 similar comment
@sbidoul
Copy link
Member

sbidoul commented Mar 5, 2015

👍

@sbidoul
Copy link
Member

sbidoul commented Mar 5, 2015

After thinking twice, I'm rather 👎 for the added dependency. At least this test reveals issue #111

I'm ok with the fast_suite removal, though.

…ue is treated in #111 and this modification is not good because it hides the failing of the tests. Since the issue #111 has not been fixed, it is normal that the test fails.
@matthieuchoplin
Copy link
Author

Thanks for the review.
I did no see that this issue was related to something else: #112 and #131.
I remove the dependancy.

@sbidoul
Copy link
Member

sbidoul commented Mar 5, 2015

Thanks! 👍

Merging immediately because of triviality.

sbidoul added a commit that referenced this pull request Mar 5, 2015
…x_137

Remove deprecated idiom in test suite
@sbidoul sbidoul merged commit bb2713a into OCA:8.0 Mar 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants